Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): Update npm cyclonedx/bom to cyclonedx-npm #4342

Merged
merged 8 commits into from
May 11, 2023
Merged

Conversation

ashlymat
Copy link
Member

@ashlymat ashlymat commented May 2, 2023

Changes

As part of #4081, temporarily cyclone dx was pinned to @cyclonedx/bom@^3.10.6.
We need to move to https://github.com/CycloneDX/cyclonedx-node-npm

This PR

  • does the above change pinning to latest version

  • also updates the Cyclone Dx schema from 1.3 to 1.4

  • changes the way cycloneDx module is installed --> installed via npx globally as per here

  • related Unit tests fixed

  • Tests

  • Documentation

@ashlymat ashlymat marked this pull request as ready for review May 5, 2023 14:05
@ashlymat ashlymat requested a review from a team as a code owner May 5, 2023 14:05
@ashlymat
Copy link
Member Author

ashlymat commented May 5, 2023

/it-go

@ashlymat ashlymat marked this pull request as draft May 5, 2023 16:04
@ashlymat ashlymat marked this pull request as ready for review May 5, 2023 17:04
pkg/npm/npm.go Outdated Show resolved Hide resolved
pkg/npm/npm.go Outdated Show resolved Hide resolved
pkg/npm/npm.go Show resolved Hide resolved
pkg/npm/npm.go Show resolved Hide resolved
pkg/npm/npm.go Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@CCFenner CCFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@CCFenner CCFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ashlymat
Copy link
Member Author

/it-go

@ashlymat ashlymat merged commit f476e8d into master May 11, 2023
@ashlymat ashlymat deleted the npm/cycloneDx branch May 11, 2023 07:55
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* fix(npm): Update npm cycloneDx to cyclonedx-npm

* Remove --no-validate and fix ut

* remove global

* Change to npm

* Apply suggestions from code review

---------

Co-authored-by: Christopher Fenner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants