feat(cnbBuild): use SHA256 hashed values for redacted telemetry properties #4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/it |
c0d1ngm0nk3y
approved these changes
Apr 17, 2023
| assert.Equal(t, "<redacted>", image) | ||
| } | ||
|
|
||
| assert.ElementsMatch(t, filtered, []string{ |
There was a problem hiding this comment.
I guess what unit test might be worth having: When the same buildpack is used several time (multiple images), will the sha256 be the same?
Most likely yes because of the Reset(), but it might be worth a test to document this. Because this is the main reason for us to use sha in the first place, to identify our buildpacks / builder later.
pbusko
force-pushed
the
cnbbuild-hash-redacted-telemetry
branch
from
19927eb to
bcc1a29
Compare
|
/it |
|
Kudos, SonarCloud Quality Gate passed!
|
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
…rties (SAP#4328) * feat(cnbBuild): use SHA256 hashed values for redacted telemetry properties * update unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of hardcoding
<redacted>string in telemetry, use SHA256 hashed strings.