Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helmExecute): Allow custom delimiter #4312

Merged
merged 3 commits into from
May 8, 2023

Conversation

c0d1ngm0nk3y
Copy link
Member

Allow custom delimiter for go templating in case the values.yaml file already contain templates that are meant to be resolved by helm and not piper (see unit test for an example).

Changes

  • Tests
  • Documentation

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner March 31, 2023 13:22
@loewenstein
Copy link

@Amandeep87 Could you please add a review for this to the backlog. Thanks.

@c0d1ngm0nk3y
Copy link
Member Author

/it

@c0d1ngm0nk3y c0d1ngm0nk3y enabled auto-merge (squash) May 5, 2023 11:48
@c0d1ngm0nk3y c0d1ngm0nk3y requested review from pbusko and modulo11 May 5, 2023 11:52
modulo11 and others added 3 commits May 8, 2023 16:10
@c0d1ngm0nk3y c0d1ngm0nk3y force-pushed the helm-execute-custom-delimiter branch from b3c519e to d2f7fda Compare May 8, 2023 14:11
@c0d1ngm0nk3y
Copy link
Member Author

/it

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from kulhadia May 8, 2023 14:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@c0d1ngm0nk3y c0d1ngm0nk3y merged commit 019ef17 into master May 8, 2023
@c0d1ngm0nk3y c0d1ngm0nk3y deleted the helm-execute-custom-delimiter branch May 8, 2023 14:24
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Jan von Loewenstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants