Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerExecuteOnKubernetes: return result of body closure #4301

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

marcusholl
Copy link
Member

Changes

With #4293 the body closure is not the last statement which gets executed. With that the return value of the call method changed (transitively via executeOnPod.

This change in the behaviour is fixed with this change.

  • Tests
  • Documentation

@marcusholl marcusholl requested a review from a team as a code owner March 27, 2023 07:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@o-liver o-liver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@o-liver
Copy link
Member

o-liver commented Mar 27, 2023

/go-it

@marcusholl marcusholl merged commit d76246d into master Mar 27, 2023
@marcusholl marcusholl deleted the marcusholl/pr/fixDockerExecuteOnKubernetes branch March 27, 2023 07:42
kamil7108 pushed a commit to kamil7108/jenkins-library that referenced this pull request Apr 3, 2023
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants