Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes): invalidate default stash only if it has been created #4273

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

marcusholl
Copy link
Member

Changes

Inside dockerExecuteOnKubernetes there is a default stash created for stashing the workspace into a pod. This default stash is only provided in case no stashes are explicitly provided. But also when there is no default stash use (... since we have explicit stashes), the default stash is invalidated.

  • Tests
  • Documentation

@marcusholl marcusholl requested a review from a team as a code owner March 14, 2023 14:35
@marcusholl marcusholl requested review from CCFenner and alxsap March 14, 2023 14:35
Copy link
Member

@CCFenner CCFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CCFenner CCFenner changed the title invalidate default stash only if it has been created feat(kubernetes): invalidate default stash only if it has been created Mar 15, 2023
@marcusholl
Copy link
Member Author

Tested with local setup.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@marcusholl marcusholl merged commit b835498 into SAP:master Mar 17, 2023
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants