Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to default cf create-service implementation #4224

Merged
merged 9 commits into from
Mar 8, 2023
Merged

Change to default cf create-service implementation #4224

merged 9 commits into from
Mar 8, 2023
+63 −141

Conversation

DanielMieg
Copy link
Member

@DanielMieg DanielMieg commented Feb 9, 2023 •
edited
Loading

Changes

  • Tests
  • Documentation

ToDo

  • Add pipeline defaults

@DanielMieg DanielMieg marked this pull request as ready for review February 23, 2023 14:40
@DanielMieg DanielMieg requested review from a team as code owners February 23, 2023 14:40
@DanielMieg
Copy link
Member Author

/it

tiloKo
tiloKo approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@tiloKo tiloKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiloKo
Copy link
Member

tiloKo commented Mar 7, 2023

/it

@DanielMieg DanielMieg requested a review from CCFenner March 7, 2023 09:00
@DanielMieg
Copy link
Member Author

@CCFenner could you have a quick look at the cfCreateService part?

@DanielMieg
Copy link
Member Author

/it

@DanielMieg
Copy link
Member Author

/it

@DanielMieg
Copy link
Member Author

/it

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DanielMieg DanielMieg enabled auto-merge (squash) March 8, 2023 08:34
@DanielMieg DanielMieg merged commit 8084ce1 into SAP:master Mar 8, 2023
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@DanielMieg @tiloKo @maxatsap
Change to default cf create-service implementation (SAP#4224)
15e296b 
* Change to default cf create-service

* Adapt test

* Adapt tests

* Remove comment

---------

Co-authored-by: tiloKo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiloKo tiloKo tiloKo approved these changes

@radsoulbeard radsoulbeard Awaiting requested review from radsoulbeard

@CCFenner CCFenner Awaiting requested review from CCFenner

Assignees
No one assigned
Labels
ABAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMieg @tiloKo