Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detectExecuteScan) execution of rapid scans #4211

Merged
merged 24 commits into from
Mar 2, 2023
Merged

feat(detectExecuteScan) execution of rapid scans #4211

merged 24 commits into from
Mar 2, 2023

Conversation

akram8008
Copy link
Contributor

@akram8008 akram8008 commented Feb 2, 2023

Changes

  1. About feature
    1. Documentation url (not final version)
  2. In part of the code
    1. A new GetProvider() method has been added to the cmd/detectExecuteScan.go file
    2. Used the GetProvider() method to detect the pull request
    3. When a pull request is detected, additional parameters will be added:
      1. "--detect.blackduck.scan.mode='RAPID'" - to change scan mode from "FULL" to "RAPID"
      2. "--detect.blackduck.rapid.compare.mode='BOM_COMPARE_STRICT'" - for package list comparison method
      3. "--detect.cleanup=false" - in order not to clear the scan results file
      4. "--detect.output.path='report'" - the path to save the results file
    4. Added the ability to read from a result file and send it to the pull request comment in markdown format

@akram8008 akram8008 requested a review from a team as a code owner February 2, 2023 17:26
@OliverNocon OliverNocon changed the title Feature/detect execuation pr scans Feature/detect execution - rapid scans Feb 2, 2023
@OliverNocon OliverNocon changed the title Feature/detect execution - rapid scans feat(detectExecuteScan) execution of rapid scans Feb 2, 2023
@Amandeep87
Copy link
Member

@akram8008 Could you add description to this PR?

@akram8008
Copy link
Contributor Author

@akram8008 Could you add description to this PR?

Description

  1. About feature
    1. Documentation url (not final version)
  2. In part of the code
    1. A new GetProvider() method has been added to the cmd/detectExecuteScan.go file
    2. Used the GetProvider() method to detect the pull request
    3. When a pull request is detected, additional parameters will be added:
      1. "--detect.blackduck.scan.mode='RAPID'" - to change scan mode from "FULL" to "RAPID"
      2. "--detect.blackduck.rapid.compare.mode='BOM_COMPARE_STRICT'" - for package list comparison method
      3. "--detect.cleanup=false" - in order not to clear the scan results file
      4. "--detect.output.path='report'" - the path to save the results file
    4. Added the ability to read from a result file and send it to the pull request comment in markdown format

@sumeetpatil
Copy link
Contributor

/it-go

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sumeetpatil
Copy link
Contributor

/it-go

@andrew-kireev andrew-kireev merged commit f4fbf0f into SAP:master Mar 2, 2023
@akram8008 akram8008 deleted the feature/detectExecuation_PR_scans branch April 11, 2023 00:04
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024

Co-authored-by: akram8008 <[email protected]>
Co-authored-by: Christopher Fenner <[email protected]>
Co-authored-by: Andrei Kireev <[email protected]>
Co-authored-by: ffeldmann <[email protected]>
Co-authored-by: sumeet patil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants