Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter for async execution (cfCreateServiceKey) #4209

Merged
merged 9 commits into from
Feb 8, 2023
Merged

Add parameter for async execution (cfCreateServiceKey) #4209

merged 9 commits into from
Feb 8, 2023

Conversation

DanielMieg
Copy link
Member

@DanielMieg DanielMieg commented Feb 1, 2023 •
edited
Loading

Changes

  • Tests
  • Documentation

@DanielMieg DanielMieg marked this pull request as ready for review February 1, 2023 13:53
@DanielMieg DanielMieg requested review from a team as code owners February 1, 2023 13:53
tiloKo
tiloKo approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@tiloKo tiloKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiloKo
Copy link
Member

tiloKo commented Feb 1, 2023

/it

1 similar comment
@DanielMieg
Copy link
Member Author

/it

@tiloKo
Copy link
Member

tiloKo commented Feb 2, 2023

/it

@DanielMieg
Copy link
Member Author

/it

@DanielMieg
Copy link
Member Author

/it

@DanielMieg DanielMieg added the ABAP label Feb 7, 2023
@DanielMieg
Copy link
Member Author

/it

@DanielMieg
Copy link
Member Author

/it

1 similar comment
@DanielMieg
Copy link
Member Author

/it

@DanielMieg DanielMieg enabled auto-merge (squash) February 8, 2023 14:21
@DanielMieg
Copy link
Member Author

/it

@DanielMieg DanielMieg merged commit 54d0c68 into SAP:master Feb 8, 2023
@DanielMieg DanielMieg deleted the addParameterServiceKey branch February 9, 2023 09:03
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@DanielMieg @tiloKo @maxatsap
Add parameter for async execution (cfCreateServiceKey) (SAP#4209)
3ba6320 
* Add parameter for async execution

* Add default

* Adapt tests

* Add defaults for ABAP

---------

Co-authored-by: tiloKo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiloKo tiloKo tiloKo approved these changes

Assignees
No one assigned
Labels
ABAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMieg @tiloKo