Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkmarx) Improve project branching process #4180

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

hubadr
Copy link
Member

@hubadr hubadr commented Jan 6, 2023

Use new Checkmarx APIs to poll the status of the branching before scanning.
If the branching is not completed and Piper starts the scan, it will fail with an error like The scan's project is either temporarily inactive or deleted. or scan canceled

Use new Checkmarx APIs to poll the status of the branching before scanning.
@hubadr hubadr requested a review from a team as a code owner January 6, 2023 11:30
@hubadr hubadr changed the title Improve project branching process fix(checkmarx) Improve project branching process Jan 6, 2023
@hubadr hubadr requested a review from thtri January 6, 2023 11:31
Copy link
Member

@thtri thtri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The function CreateBranch now requires two different HTTP requests and therefore two responses to be mocked. It does not seem to be supported by the mocking mechanism in Piper currently.
@hubadr
Copy link
Member Author

hubadr commented Jan 6, 2023

/it-go

@hubadr hubadr merged commit 394196e into SAP:master Jan 6, 2023
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* Improve project branching process

Use new Checkmarx APIs to poll the status of the branching before scanning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants