Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(versioning): ensure that version is not empty #4173

Merged
merged 5 commits into from
Apr 29, 2024
Merged

fix(versioning): ensure that version is not empty #4173

merged 5 commits into from
Apr 29, 2024

Conversation

OliverNocon
Copy link
Member

Changes

fixes a problem which appeared in a golang build where an empty version was propagated.

@OliverNocon OliverNocon requested a review from a team as a code owner December 23, 2022 11:43
@Amandeep87 Amandeep87 added the REVIEW Pull-Request needs a review label Jan 12, 2023
@github-actions
Copy link
Contributor

Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Mar 14, 2023
@github-actions
Copy link
Contributor

Pull request got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant.

@github-actions github-actions bot closed this Mar 25, 2023
@OliverNocon OliverNocon removed the stale marks stale issues and pull requests label Dec 21, 2023
@OliverNocon OliverNocon reopened this Dec 21, 2023
@OliverNocon OliverNocon requested a review from a team as a code owner December 21, 2023 08:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Mar 12, 2024
@OliverNocon OliverNocon removed the stale marks stale issues and pull requests label Mar 19, 2024
tiloKo
tiloKo approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@tiloKo tiloKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiloKo
Copy link
Member

tiloKo commented Mar 25, 2024

/it

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OliverNocon OliverNocon enabled auto-merge (squash) April 29, 2024 06:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OliverNocon
Copy link
Member Author

/it-go

@OliverNocon OliverNocon merged commit 7d9fc6a into master Apr 29, 2024
12 checks passed
@OliverNocon OliverNocon deleted the versioningFix branch April 29, 2024 06:19
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@OliverNocon @tiloKo @maxatsap
fix(versioning): ensure that version is not empty (SAP#4173)
719a0d9 
Co-authored-by: tiloKo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiloKo tiloKo tiloKo approved these changes

@anilkeshav27 anilkeshav27 Awaiting requested review from anilkeshav27

Assignees
No one assigned
Labels
bug 🐛 REVIEW Pull-Request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OliverNocon @tiloKo @Amandeep87