Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cnbBuild): fix containerImageAlias examples #4171

Merged
merged 1 commit into from
Dec 21, 2022
Merged

docs(cnbBuild): fix containerImageAlias examples #4171

merged 1 commit into from
Dec 21, 2022
+10 −7

Conversation

pbusko
Copy link
Member

@pbusko pbusko commented Dec 21, 2022

Changes

  • Tests
  • Documentation

@pbusko pbusko requested review from a team as code owners December 21, 2022 13:38
@pbusko pbusko changed the title docs(cnbBuild): fix containerImageAlias examples docs(cnbBuild): fix containerImageAlias examples Dec 21, 2022
@pbusko
Copy link
Member Author

pbusko commented Dec 21, 2022

/it-go

loewenstein
loewenstein reviewed Dec 21, 2022
View reviewed changes
Copy link

@loewenstein loewenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the unrelated file with whitespace to cleanly merge on our own?

@pbusko
Copy link
Member Author

pbusko commented Dec 21, 2022 •
edited
Loading

Should we remove the unrelated file with whitespace to cleanly merge on our own?

The indentation was fixed automatically by go generate. We can remove it, but the next time we change something and we need to run go generate, the same change will appear again.

Also I can't change it in VSCode, it runs go fmt automatically on save and puts the whitespace back 😄

@pbusko pbusko force-pushed the cnbbuild-fix-alias-doc branch from 03711af to 6af8bec Compare December 21, 2022 13:50
@pbusko pbusko requested a review from a team as a code owner December 21, 2022 13:50
@pbusko pbusko force-pushed the cnbbuild-fix-alias-doc branch from 6af8bec to 648e5e2 Compare December 21, 2022 13:53
@pbusko pbusko requested review from loewenstein and a team and removed request for a team and loewenstein December 21, 2022 13:54
@pbusko
Copy link
Member Author

pbusko commented Dec 21, 2022

/it-go

@pbusko pbusko enabled auto-merge (squash) December 21, 2022 13:55
@pbusko
Copy link
Member Author

pbusko commented Dec 21, 2022

/it-go

@pbusko pbusko merged commit 6201e9b into master Dec 21, 2022
@pbusko pbusko deleted the cnbbuild-fix-alias-doc branch December 21, 2022 15:47
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@pbusko @maxatsap
docs(cnbBuild): fix containerImageAlias examples (SAP#4171)
c54d09e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modulo11 modulo11 modulo11 approved these changes

@loewenstein loewenstein Awaiting requested review from loewenstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbusko @loewenstein @modulo11