githubCreateIssue_fix #4151
Merged
githubCreateIssue_fix #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/it-go |
1 similar comment
|
/it-go |
jliempt
reviewed
Dec 14, 2022
There was a problem hiding this comment.
Looks neat! I noticed an issue though.
I have tested it with a test repository, but I think it can happen that the POST requests are made too fast after each other when the body is split up in chunks. When slowly stepping through the code it works well, but when running it normally, I saw it happening that multiple issues are opened with the chunks.
Comment on lines
+36
to
+43
| - name: chunkSize | ||
| description: Defines size of the chunk. If content exceed chunk size it'll be sliced into chunks and stored in comments | ||
| scope: | ||
| - PARAMETERS | ||
| - STAGES | ||
| - STEPS | ||
| type: int | ||
| default: 65500 |
There was a problem hiding this comment.
Should it be made clear what the maximum value is? Or what happens if you set chunkSize above it?
Co-authored-by: Jordi van Liempt <[email protected]>
…y into githubCreateIssue-fix
jliempt
approved these changes
Dec 15, 2022
|
/it-go |
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* extend githubCreateIssue to handle long body Co-authored-by: Jordi van Liempt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ghCreateIssue throws error when message body exceeds 65536 characters
For some cases body reaches the limit of issues body (65536 characters)
Possible solution: once body reaches the limit - split leftovers into the comments