integrationArtifactTransport Command #4131

mayurmohan · 2022-11-21T05:26:57Z

Changes

integrationArtifactTransport Command :- Integration artifact content transport using SAP Content Agent service

Tests
Documentation

cla-assistant · 2022-11-21T05:27:11Z

All committers have signed the CLA.

srinikitha09

Few typos

documentation/docs/steps/integrationArtifactTransport.md

LindaSieb · 2022-11-25T14:48:36Z

documentation/docs/steps/integrationArtifactTransport.md

+
+With this step, you can transport SAP Cloud Integration content across various landscapes using SAP Content Agent Service.
+
+SAP Cloud Integration provides content transport mechanism. SAP Content Agent service enables you to assemble the content from these content providers in MTAR format. Later, this content is either available for download or exported to the configured transport queue, such as SAP Cloud Transport Management. For more information on


Can you explain just a bit more what you mean by "SAP Cloud Integration provides content transport mechanism."? Do you mean that SAP Cloud Integration is a content provider? (You mention content providers in the next sentence, but which content providers do you mean?)

there is a separate review happen for documentation part by the Documentation experts, i would suggest not review the .md. .yaml content in detail

Since the documentation is my main way (and probably the main way for other people) to understand what this step is supposed to do, I would like a bit more explanation there if you could add that. When will the documentation experts review this? I can wait to add my review until they've made changes.

After the documentation review, I'm still left with some questions about what exactly this step does and what the documentation is saying. Could you please elaborate on "SAP Cloud Integration provides content transport mechanism." Is there any other documentation you could link here? Also you mention content providers in the next sentence, but which content providers do you mean?

Since I'm not a Integration Suite expert, my suggestions won't be completely accurate. @AnnikaGonnermann and @axelalbrechtsap maybe you could support here with adding more detail to the documentation from the point of view of Integration Suite? I think it should be written for someone that has no idea what this step should do.

2 points:

"SAP Cloud Integration provides content transport mechanism" used in the already referred public documentation which we also used as is (https://help.sap.com/docs/CONTENT_AGENT_SERVICE/ae1a4f2d150d468d9ff56e13f9898e07/8e274fdd41da45a69ff919c0af8c6127.html)

there is blog linked in the last step which provide step by step instruction how to do integration package transport with CAS, TMS (https://blogs.sap.com/2022/03/25/transport-sap-cloud-integration-ci-cpi-content-with-transport-management-service-tms-and-content-agent-service-cas/)

i feel this is good enough from documentation standpoint.

documentation/docs/steps/integrationArtifactTransport.md

cmd/integrationArtifactTransport_test.go

cmd/integrationArtifactTransport.go

documentation/docs/steps/integrationArtifactTransport.md

LindaSieb

Since I'm not sure how to test this, could you please upload some sort of evidence that it worked properly? A screenshot of logs maybe? (of course without any sensitive information)

mayurmohan · 2022-12-07T04:44:22Z

Since I'm not sure how to test this, could you please upload some sort of evidence that it worked properly? A screenshot of logs maybe? (of course without any sensitive information)
please refer below details:

Jenkins Job Log:

TMSLog:

TMSQueue :

Logs:
consoleText.txt

test/groovy/CommonStepsTest.groovy

LindaSieb

Documentation suggestions. Please let me know if I've misunderstood the step 🙂

documentation/docs/steps/integrationArtifactTransport.md

resources/metadata/integrationArtifactTransport.yaml

documentation/docs/steps/integrationArtifactTransport.md

LindaSieb

Thanks @mayurmohan! 🙂

LindaSieb · 2022-12-16T09:28:17Z

/it

LindaSieb · 2022-12-16T10:23:37Z

/it

LindaSieb · 2022-12-16T11:51:45Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 4 committers have signed the CLA.✅ mayurmohan✅ LindaSieb❌ I050368❌ srinikitha09

I050368 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@I050368 and @srinikitha09 could you sign the license agreement?

LindaSieb · 2022-12-16T11:52:22Z

@I050368 and @srinikitha09 could you sign the license agreement?

@mayurmohan are you I050368? It looks like some tests are failing because "I050368" hasn't signed the license agreement

LindaSieb · 2022-12-20T08:35:54Z

@I050368 and @srinikitha09 could you sign the license agreement?

@mayurmohan are you I050368? It looks like some tests are failing because "I050368" hasn't signed the license agreement

"I050368 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account."

LindaSieb · 2022-12-20T08:36:38Z

/it

Co-authored-by: Srinikitha Kondreddy <[email protected]>

Co-authored-by: Linda Siebert <[email protected]>

LindaSieb · 2022-12-20T10:56:43Z

/it

* integrationArtifactTransport Command * CodeReview Fix * CodeReview Fix * codereview fix * Update documentation/docs/steps/integrationArtifactTransport.md Co-authored-by: Srinikitha Kondreddy <[email protected]> * Update documentation/docs/steps/integrationArtifactTransport.md Co-authored-by: Srinikitha Kondreddy <[email protected]> * CodeReview Fixes * CodeReview FIxes * CodeReview Fix * Doc Fixes * Update documentation/docs/steps/integrationArtifactTransport.md Co-authored-by: Linda Siebert <[email protected]> * Doc fixes * Doc Fixes * CodeReview Fixes * Doc Fixes Co-authored-by: Linda Siebert <[email protected]> Co-authored-by: Srinikitha Kondreddy <[email protected]> Co-authored-by: Linda Siebert <[email protected]>

mayurmohan requested a review from a team as a code owner November 21, 2022 05:26

srinikitha09 reviewed Nov 25, 2022

View reviewed changes

documentation/docs/steps/integrationArtifactTransport.md Outdated Show resolved Hide resolved

documentation/docs/steps/integrationArtifactTransport.md Outdated Show resolved Hide resolved

LindaSieb reviewed Nov 25, 2022

View reviewed changes

LindaSieb reviewed Dec 6, 2022

View reviewed changes

documentation/docs/steps/integrationArtifactTransport.md Outdated Show resolved Hide resolved

LindaSieb requested changes Dec 6, 2022

View reviewed changes

LindaSieb reviewed Dec 9, 2022

View reviewed changes

test/groovy/CommonStepsTest.groovy Outdated Show resolved Hide resolved

LindaSieb requested changes Dec 12, 2022

View reviewed changes

LindaSieb approved these changes Dec 16, 2022

View reviewed changes

LindaSieb force-pushed the integrationArtifactTransport branch from 860f804 to e6803cb Compare December 20, 2022 10:53

LindaSieb requested review from inf2381 and a team as code owners December 20, 2022 10:53

LindaSieb and others added 10 commits December 20, 2022 11:54

integrationArtifactTransport Command

61cbd8c

CodeReview Fix

a483e79

CodeReview Fix

4fceeea

codereview fix

47b606c

Update documentation/docs/steps/integrationArtifactTransport.md

5aead46

Co-authored-by: Srinikitha Kondreddy <[email protected]>

Update documentation/docs/steps/integrationArtifactTransport.md

8074463

Co-authored-by: Srinikitha Kondreddy <[email protected]>

CodeReview Fixes

52b91f0

CodeReview FIxes

c90783c

CodeReview Fix

5997dcc

Doc Fixes

24e522a

mayurmohan and others added 5 commits December 20, 2022 11:54

Update documentation/docs/steps/integrationArtifactTransport.md

ac67a37

Co-authored-by: Linda Siebert <[email protected]>

Doc fixes

0653502

Doc Fixes

4809bee

CodeReview Fixes

6f520ed

Doc Fixes

c547de5

LindaSieb force-pushed the integrationArtifactTransport branch from e6803cb to c547de5 Compare December 20, 2022 10:55

LindaSieb enabled auto-merge (squash) December 20, 2022 11:05

LindaSieb merged commit a65df9c into SAP:master Dec 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

integrationArtifactTransport Command #4131

integrationArtifactTransport Command #4131

mayurmohan commented Nov 21, 2022

cla-assistant bot commented Nov 21, 2022 •

edited

Loading

srinikitha09 left a comment

LindaSieb Nov 25, 2022

mayurmohan Nov 30, 2022

mayurmohan Nov 30, 2022

LindaSieb Dec 6, 2022

LindaSieb Dec 9, 2022

mayurmohan Dec 12, 2022

LindaSieb left a comment

mayurmohan commented Dec 7, 2022 •

edited

Loading

LindaSieb left a comment

LindaSieb left a comment

LindaSieb commented Dec 16, 2022

LindaSieb commented Dec 16, 2022

LindaSieb commented Dec 16, 2022

LindaSieb commented Dec 16, 2022

LindaSieb commented Dec 20, 2022 •

edited

Loading

LindaSieb commented Dec 20, 2022

LindaSieb commented Dec 20, 2022


		With this step, you can transport SAP Cloud Integration content across various landscapes using SAP Content Agent Service.

		SAP Cloud Integration provides content transport mechanism. SAP Content Agent service enables you to assemble the content from these content providers in MTAR format. Later, this content is either available for download or exported to the configured transport queue, such as SAP Cloud Transport Management. For more information on

integrationArtifactTransport Command #4131

integrationArtifactTransport Command #4131

Conversation

mayurmohan commented Nov 21, 2022

Changes

cla-assistant bot commented Nov 21, 2022 • edited Loading

srinikitha09 left a comment

Choose a reason for hiding this comment

LindaSieb Nov 25, 2022

Choose a reason for hiding this comment

mayurmohan Nov 30, 2022

Choose a reason for hiding this comment

mayurmohan Nov 30, 2022

Choose a reason for hiding this comment

LindaSieb Dec 6, 2022

Choose a reason for hiding this comment

LindaSieb Dec 9, 2022

Choose a reason for hiding this comment

mayurmohan Dec 12, 2022

Choose a reason for hiding this comment

LindaSieb left a comment

Choose a reason for hiding this comment

mayurmohan commented Dec 7, 2022 • edited Loading

LindaSieb left a comment

Choose a reason for hiding this comment

LindaSieb left a comment

Choose a reason for hiding this comment

LindaSieb commented Dec 16, 2022

LindaSieb commented Dec 16, 2022

LindaSieb commented Dec 16, 2022

LindaSieb commented Dec 16, 2022

LindaSieb commented Dec 20, 2022 • edited Loading

LindaSieb commented Dec 20, 2022

LindaSieb commented Dec 20, 2022

cla-assistant bot commented Nov 21, 2022 •

edited

Loading

mayurmohan commented Dec 7, 2022 •

edited

Loading

LindaSieb commented Dec 20, 2022 •

edited

Loading