Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maven spotbugs plugin to support Java 14 #1852

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Update maven spotbugs plugin to support Java 14 #1852

merged 2 commits into from
Jul 28, 2020

Conversation

fwilhe
Copy link
Contributor

@fwilhe fwilhe commented Jul 27, 2020

Changes

  • Tests
  • Documentation

@fwilhe fwilhe changed the title Update mavenExecuteStaticCodeChecks.go Update maven spotbugs plugin to support Java 14 Jul 28, 2020
@fwilhe fwilhe marked this pull request as ready for review July 28, 2020 07:33
stippi2
stippi2 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@stippi2 stippi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion: You could add a constant in mavenExecuteStaticCodeChecks.go.

@fwilhe fwilhe merged commit 60796cd into master Jul 28, 2020
@fwilhe fwilhe deleted the java11 branch July 28, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stippi2 stippi2 stippi2 approved these changes

@daniel-kurzynski daniel-kurzynski daniel-kurzynski approved these changes

@CCFenner CCFenner Awaiting requested review from CCFenner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwilhe @daniel-kurzynski @stippi2