Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests don't work with java 11 #1723

Closed
fwilhe opened this issue Jun 26, 2020 · 3 comments
Closed

Unit tests don't work with java 11 #1723

fwilhe opened this issue Jun 26, 2020 · 3 comments
Labels
stale marks stale issues and pull requests

Comments

@fwilhe
Copy link
Contributor

fwilhe commented Jun 26, 2020

To reproduce:

Try both the same thing in maven:3-jdk-8 and maven:3-jdk-11 docker image respectively:

Clone this repo, cd into, run mvn verify

If using java 8, it works.

If using java 11 you'll get loads of errors like

[ERROR] /jenkins-library/src/com/sap/piper/MapUtils.groovy:[3,7] 2849. ERROR in /jenkins-library/src/com/sap/piper/MapUtils.groovy (at line 3)
[ERROR] 	class MapUtils implements Serializable {
[ERROR] 	      ^^^^^^^^
@fwilhe
Copy link
Contributor Author

fwilhe commented Jun 26, 2020

Maybe this can be easily fixed by updating some dependencies in the pom.

fwilhe added a commit that referenced this issue Mar 11, 2021
Workaround for #1723, because Ubuntu 20.04 VMs include Java 11 by default
CCFenner pushed a commit that referenced this issue Apr 16, 2021
Workaround for #1723, because Ubuntu 20.04 VMs include Java 11 by default
@github-actions
Copy link
Contributor

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Dec 18, 2021
@github-actions
Copy link
Contributor

Issue got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale marks stale issues and pull requests
Projects
None yet
Development

No branches or pull requests

1 participant