fix: get purl arguments

cmd/mavenBuild.go

@@ -254,7 +254,7 @@ func createBuildArtifactsMetadata(config *mavenBuildOptions, commonPipelineEnvir
 			} else {
 				coordinate.BuildPath = filepath.Dir(match)
 				coordinate.URL = config.AltDeploymentRepositoryURL
-				coordinate.PURL = piperutils.GetPurl(match, mvnSimpleBomFilename+".xml")
+				coordinate.PURL = piperutils.GetPurl(filepath.Join(match, "/target/"+mvnSimpleBomFilename+".xml"))
 				buildCoordinates = append(buildCoordinates, coordinate)
 			}
 		}

cmd/mtaBuild.go

@@ -330,7 +330,7 @@ func buildArtifactsMetadata(config mtaBuildOptions, commonPipelineEnvironment *m
 				Packaging:  "mtar",
 				BuildPath:  filepath.Dir(mtarPath),
 				URL:        config.MtaDeploymentRepositoryURL,
-				PURL:       piperutils.GetPurl(mtarPath, "sbom-gen/bom-mta.xml"),
+				PURL:       piperutils.GetPurl(filepath.Join(mtarPath, "sbom-gen/bom-mta.xml")),
 			},
 		},
 	}

pkg/npm/publish.go

@@ -218,7 +218,7 @@ func (exec *Execute) publish(packageJSON, registry, username, password string, p
 			coordinate.BuildPath = filepath.Dir(packageJSON)
 			coordinate.URL = registry
 			coordinate.Packaging = "tgz"
-			coordinate.PURL = piperutils.GetPurl(packageJSON, npmBomFilename)
+			coordinate.PURL = piperutils.GetPurl(filepath.Join(packageJSON, npmBomFilename))
 
 			*buildCoordinates = append(*buildCoordinates, coordinate)
 		}

pkg/piperutils/cyclonedxBom.go

@@ -4,7 +4,6 @@ import (
 	"encoding/xml"
 	"io"
 	"os"
-	"path/filepath"
 
 	"github.com/SAP/jenkins-library/pkg/log"
 )
@@ -49,17 +48,7 @@ func GetBom(absoluteBomPath string) (Bom, error) {
 	return bom, nil
 }
 
-func GetPurl(filePath, bomFilename string) string {
-	bomFilePath := filepath.Join(filepath.Dir(filePath), bomFilename)
-	exists, err := FileExists(bomFilePath)
-	if err != nil {
-		log.Entry().Warnf("unable to check if bom file exists: %v", err)
-		return ""
-	}
-	if !exists {
-		log.Entry().Debugf("bom file doesn't exist and hence no pURL info: %v", bomFilePath)
-		return ""
-	}
+func GetPurl(bomFilePath string) string {
 	bom, err := GetBom(bomFilePath)
 	if err != nil {
 		log.Entry().Warnf("unable to get bom metadata: %v", err)

pkg/piperutils/cyclonedxbom_test.go

@@ -143,7 +143,7 @@ func TestGetPurl(t *testing.T) {
 				filePath = "nonexistent.xml"
 			}
 
-			purl := GetPurl(filePath, "test.xml")
+			purl := GetPurl(filePath)
 			if purl != tt.expectedPurl {
 				t.Errorf("Expected PURL: %v, got: %v", tt.expectedPurl, purl)
 			}