Skip to content

Commit

Permalink
Merge branch 'develop'
Browse files Browse the repository at this point in the history
  • Loading branch information
tal-mi committed Dec 20, 2023
2 parents a40f87c + e0c9cc8 commit 618f71b
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 15 deletions.
8 changes: 4 additions & 4 deletions sdk-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ implementation 'com.google.code.gson:gson:2.8.9'
### Implement using binaries
**Download the latest build and place the .aar file in your */libs* folder**
```gradle
implementation files('libs/gigya-android-sdk-core-v7.0.7.aar')
implementation files('libs/gigya-android-sdk-core-v7.0.8.aar')
```

### Implement using **MavenCentral**
**Add the latest build reference to your app *build.gradle* file**
```gradle
implementation 'com.sap.oss.gigya-android-sdk:sdk-core:7.0.7'
implementation 'com.sap.oss.gigya-android-sdk:sdk-core:7.0.8'
```

### Implement using Jitpack (Will be soon deprecated - moving to Maven Central)
Expand All @@ -43,7 +43,7 @@ allprojects {
```
**Add the latest build reference to your app *build.gradle* file**
```gradle
implementation 'com.github.SAP.gigya-android-sdk:sdk-core:core-v7.0.7'
implementation 'com.github.SAP.gigya-android-sdk:sdk-core:core-v7.0.8'
```

**Add a required style to your *styles.xml* file**
Expand Down Expand Up @@ -75,7 +75,7 @@ android:theme="@style/Theme.AppCompat.Translucent">
### OKHttp Support

The core SDK now supports using the OKHttp library to make network requests (which deprecates the use of the obsolete HttpUrlConnection & Volley).
To use the OKHttp library, please add the following to your application dependencies:
To use the OKHttp library, please add both of the following to your application dependencies:
```
implementation "com.squareup.okhttp3:okhttp:4.10.0"
implementation "com.squareup.okhttp3:logging-interceptor:4.10.0"
Expand Down
2 changes: 1 addition & 1 deletion sdk-core/build.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

def libVersion = "7.0.7"
def libVersion = "7.0.8"

group = "com.sap.oss.gigya-android-sdk"

Expand Down
2 changes: 1 addition & 1 deletion sdk-core/src/main/java/com/gigya/android/sdk/Gigya.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
public class Gigya<T extends GigyaAccount> {

//region static
public static final String VERSION = "7.0.7";
public static final String VERSION = "7.0.8";

private static final String LOG_TAG = "Gigya";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,10 @@ class NetworkClient {

// Add network logging if set to allow (default set to false).
if (GigyaLogger.isDebug()) {
try {
builder.addInterceptor(
HttpLoggingInterceptor()
.setLevel(HttpLoggingInterceptor.Level.BODY)
)
} catch (ex: Exception) {
// OkHttp logger implementation might not be available. should not crash.
GigyaLogger.debug("RestAdapter", "missing implementation of OkHttp logger. optional")
}
builder.addInterceptor(
HttpLoggingInterceptor()
.setLevel(HttpLoggingInterceptor.Level.BODY)
)
}
okHttpClient = builder.build()
}
Expand Down

0 comments on commit 618f71b

Please sign in to comment.