Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sort subgen list, remove threshold, fix permission issues #123

Merged
merged 1 commit into from
Jun 9, 2023
Merged

fix: sort subgen list, remove threshold, fix permission issues #123

merged 1 commit into from
Jun 9, 2023
+251 −308

Conversation

petermuessig
Copy link
Contributor

  • Sorts the sub generator list alphabetically
  • Removes the threshold of 30 for the list of sub generators
  • Fixes the permission issues for installing / updating

Fixes #122
Fixes #118
Fixes #117
Fixes #111

@petermuessig
fix: sort subgen list, remove threshold, fix permission issues
c14779d 
* Sorts the sub generator list alphabetically
* Removes the threshold of 30 for the list of sub generators
* Fixes the permission issues for installing / updating

Fixes #122
Fixes #118
Fixes #117
Fixes #111
@petermuessig
Copy link
Contributor Author

@nicoschoenteich - this is FYI - I will release this independently to get the above mentioned issues fixed. You can also take a look later on that.

@petermuessig petermuessig merged commit c5dd321 into main Jun 9, 2023
@petermuessig petermuessig deleted the fix/Various branch June 9, 2023 20:09
nicoschoenteich
nicoschoenteich reviewed Jun 12, 2023
View reviewed changes
Copy link

@nicoschoenteich nicoschoenteich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and works like a charm. Nice solution with _generator-easy-ui5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoschoenteich nicoschoenteich nicoschoenteich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petermuessig @nicoschoenteich