Skip to content

Commit

Permalink
fix: await Environment.lookup (#132) (#133)
Browse files Browse the repository at this point in the history
* fix: await Environment.lookup (#132)

* ci: update triggers + node version

* chore: bump node version to min lts

* refactor: source format

* chore(deps): lock file

* chore: bump generator version

---------

Co-authored-by: Volker Buzek <[email protected]>
  • Loading branch information
cpa-gecko and vobu authored Nov 29, 2023
1 parent 241d802 commit 9f614d2
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 8 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
name: Run test

on: push
on:
push:
pull_request:
branches:
- main

jobs:
run-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 20
registry-url: https://registry.npmjs.org/

- run: git config --global user.email "[email protected]" && git config --global user.name "Your Name"
Expand Down
3 changes: 2 additions & 1 deletion generators/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,8 @@ export default class extends Generator {

// filter the hidden subgenerators already
// -> subgenerators must be found in env as they are returned by lookup!
let subGenerators = env.lookup({ localOnly: true, packagePaths: generatorPath }).filter((sub) => {
const lookupGeneratorMeta = await env.lookup({ localOnly: true, packagePaths: generatorPath });
let subGenerators = lookupGeneratorMeta.filter((sub) => {
const subGenerator = env.get(sub.namespace);
return !subGenerator.hidden;
});
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "generator-easy-ui5",
"version": "3.6.3",
"version": "3.6.4",
"description": "Generator for UI5-based project",
"main": "generators/app/index.js",
"type": "module",
Expand All @@ -9,7 +9,7 @@
"plugins"
],
"engines": {
"node": ">=14.0.0"
"node": ">=18.0.0"
},
"scripts": {
"prepublishOnly": "npx yo ./ project --embed",
Expand Down

0 comments on commit 9f614d2

Please sign in to comment.