Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fixing the accessibility for the dialog component #6297

Merged
merged 4 commits into from
Aug 31, 2021

Conversation

Lokanathan-k
Copy link
Contributor

Please provide a link to the associated issue.

Closes: #6100

Please provide a brief summary of this pull request.

fixing the accessability test cases

Please check whether the PR fulfills the following requirements

Documentation checklist:

Sorry, something went wrong.

@Lokanathan-k Lokanathan-k added bug Something isn't working ariba to identify issues that belongs to ariba team ATL Accessibility Test Labs labels Aug 11, 2021
@Lokanathan-k Lokanathan-k self-assigned this Aug 11, 2021
@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: fa0a2fc

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/612cc8041206b900097f32c1

😎 Browse the preview: https://deploy-preview-6297--fundamental-ngx.netlify.app

@Lokanathan-k Lokanathan-k changed the title [WIP]fix(core): fixing the accessibility for the dialog component fix(core): fixing the accessibility for the dialog component Aug 11, 2021
@Lokanathan-k Lokanathan-k requested a review from a team August 11, 2021 09:06
@Lokanathan-k Lokanathan-k force-pushed the 6100_Dialog branch 2 times, most recently from 5efa6a0 to f9d84b8 Compare August 11, 2021 10:11
Copy link
Contributor

@kavya-b kavya-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you verify the netlify url against JAWS once to see if the reported issues are fixed? I randomly checked for Object Based Dialog example and it still reads

  1. whole content
  2. title twice read
    on opening dialog

image

@Lokanathan-k Lokanathan-k force-pushed the 6100_Dialog branch 7 times, most recently from 89dc3e9 to 6390f5b Compare August 13, 2021 13:35
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Aug 16, 2021
@Lokanathan-k Lokanathan-k added the ready for qa Testing should be started for the PR label Aug 27, 2021
@Seamoo13 Seamoo13 requested a review from puru-hk August 27, 2021 08:49
@puru-hk puru-hk added Testing (QA) QA testing in progress and removed ready for qa Testing should be started for the PR labels Aug 27, 2021
@puru-hk
Copy link
Contributor

puru-hk commented Aug 27, 2021

Other than issue 4 all the issues are fixed now.

Issue 4: when the button such as 'Close', 'Clear' within the dialog is accessed, extra information 'Banner region' is conveyed. This issue is still reproducible. Could you please check.

@puru-hk puru-hk added rework required Validation failed and removed Testing (QA) QA testing in progress labels Aug 27, 2021
@Lokanathan-k Lokanathan-k force-pushed the 6100_Dialog branch 2 times, most recently from 63da642 to e3c413f Compare August 27, 2021 14:36
@Lokanathan-k
Copy link
Contributor Author

Other than issue 4 all the issues are fixed now.

Issue 4: when the button such as 'Close', 'Clear' within the dialog is accessed, extra information 'Banner region' is conveyed. This issue is still reproducible. Could you please check.

Fixed

Screenshot 2021-08-27 at 10 20 07 PM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix(core): fixing the accessability test cases

fix(core): adding the aria model tag

fix(core): adding the aria model tag

fix(core): adding the aria model tag

fix(core): adding the aria model tag

fix(core): fixing the accessability test cases

fix(core): fixing the accessability test cases

fix(core): fixing the accessability test cases for the default dialog component

fix(core): fixing the accessability test cases for the default dialog component

fix(core): fixing the accessability test case Object dialog component

fix(core): fixing the accessability test case Object dialog component

fix(core): adding focus to the dialog window

fix(core): adding focus to the dialog window

fix(core): adding role to the dialog body at host

fix(core): adding role to the dialog body at host

fix(core): adding formatting text

fix(core): adding formatting text

fix(core): adding tool tip to the close button

fix(core): adding tool tip to the close button

fix(core): adding role to the dialog component at host

fix(core): adding role to the dialog component at host

fix(core): adding role to the dialog component

fix(core): adding role to the dialog component

fix(core): adding role to the dialog component

fix(core): adding role to the dialog component

Revert "fix(core): adding role to the dialog component"

This reverts commit 78066ea.

fix(core): addidng focus to the dialog box

fix(core): addidng focus to the dialog box

fix(core): addidng role as docuement

fix(core): addidng role as docuement

fix(core): removing the document on the li element

fix(core): removing the document on the li element

fix(core): fixing the aria label to read button type

fix(core): fixing the aria label to read button type

fix(core): adding i18n tag to the X button

fix(core): adding i18n tag to the X button

fix(core): fixing the aria label to read button type

fix(core): fixing the aria label to read button type

fix(core): seperating title form aria label

fix(core): seperating title form aria label

fix(core): reverting the button type reading the fdtype

fix(core): reverting the button type reading the fdtype

fix(core): adding focus trap to the code

fix(core): adding focus trap to the code

fix(core): removing unused imports and variables

fix(core): removing unused imports and variables

fix(core): skipping the regression test case

fix(core): skipping the regression test case

fix(core): removing the default focus on the dialog

fix(core): removing the default focus on the dialog

test(e2e): skip visual regression case
fix(core): removing the  header tag and replacing it with div
fix(core): fixing test cases for the dialog header
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Aug 30, 2021
@Lokanathan-k Lokanathan-k added ready for qa Testing should be started for the PR and removed stale rework required Validation failed labels Aug 30, 2021
@puru-hk
Copy link
Contributor

puru-hk commented Aug 30, 2021

Looks good

@puru-hk puru-hk added QA Approved and removed ready for qa Testing should be started for the PR labels Aug 30, 2021
@Betrozov Betrozov merged commit 1655868 into main Aug 31, 2021
@Betrozov Betrozov deleted the 6100_Dialog branch August 31, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ariba to identify issues that belongs to ariba team ATL Accessibility Test Labs bug Something isn't working QA Approved ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Accessibility Testing_Core_Dialog
9 participants