-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fixing the accessibility for the dialog component #6297
Conversation
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: fa0a2fc 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/612cc8041206b900097f32c1 😎 Browse the preview: https://deploy-preview-6297--fundamental-ngx.netlify.app |
5efa6a0
to
f9d84b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...docs/src/app/core/component-docs/dialog/examples/component-based/dialog-example.component.ts
Outdated
Show resolved
Hide resolved
...app/core/component-docs/dialog/examples/dialog-complex/dialog-complex-example.component.html
Outdated
Show resolved
Hide resolved
89dc3e9
to
6390f5b
Compare
.../app/core/component-docs/dialog/examples/auto-label/auto-label-dialog-example.component.html
Outdated
Show resolved
Hide resolved
...app/core/component-docs/dialog/examples/dialog-complex/dialog-complex-example.component.html
Outdated
Show resolved
Hide resolved
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
.../app/core/component-docs/dialog/examples/auto-label/auto-label-dialog-example.component.html
Outdated
Show resolved
Hide resolved
8d32637
to
9f8e10a
Compare
...docs/src/app/core/component-docs/dialog/examples/component-based/dialog-example.component.ts
Outdated
Show resolved
Hide resolved
...src/app/core/component-docs/dialog/examples/dialog-state/dialog-state-example.component.html
Outdated
Show resolved
Hide resolved
libs/core/src/lib/dialog/dialog-close-button/dialog-close-button.component.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/dialog/dialog-default/dialog-default.component.html
Outdated
Show resolved
Hide resolved
libs/core/src/lib/dialog/dialog-default/dialog-default.component.html
Outdated
Show resolved
Hide resolved
Other than issue 4 all the issues are fixed now. Issue 4: when the button such as 'Close', 'Clear' within the dialog is accessed, extra information 'Banner region' is conveyed. This issue is still reproducible. Could you please check. |
63da642
to
e3c413f
Compare
fix(core): fixing the accessability test cases fix(core): adding the aria model tag fix(core): adding the aria model tag fix(core): adding the aria model tag fix(core): adding the aria model tag fix(core): fixing the accessability test cases fix(core): fixing the accessability test cases fix(core): fixing the accessability test cases for the default dialog component fix(core): fixing the accessability test cases for the default dialog component fix(core): fixing the accessability test case Object dialog component fix(core): fixing the accessability test case Object dialog component fix(core): adding focus to the dialog window fix(core): adding focus to the dialog window fix(core): adding role to the dialog body at host fix(core): adding role to the dialog body at host fix(core): adding formatting text fix(core): adding formatting text fix(core): adding tool tip to the close button fix(core): adding tool tip to the close button fix(core): adding role to the dialog component at host fix(core): adding role to the dialog component at host fix(core): adding role to the dialog component fix(core): adding role to the dialog component fix(core): adding role to the dialog component fix(core): adding role to the dialog component Revert "fix(core): adding role to the dialog component" This reverts commit 78066ea. fix(core): addidng focus to the dialog box fix(core): addidng focus to the dialog box fix(core): addidng role as docuement fix(core): addidng role as docuement fix(core): removing the document on the li element fix(core): removing the document on the li element fix(core): fixing the aria label to read button type fix(core): fixing the aria label to read button type fix(core): adding i18n tag to the X button fix(core): adding i18n tag to the X button fix(core): fixing the aria label to read button type fix(core): fixing the aria label to read button type fix(core): seperating title form aria label fix(core): seperating title form aria label fix(core): reverting the button type reading the fdtype fix(core): reverting the button type reading the fdtype fix(core): adding focus trap to the code fix(core): adding focus trap to the code fix(core): removing unused imports and variables fix(core): removing unused imports and variables fix(core): skipping the regression test case fix(core): skipping the regression test case fix(core): removing the default focus on the dialog fix(core): removing the default focus on the dialog test(e2e): skip visual regression case
fix(core): removing the header tag and replacing it with div
fix(core): fixing test cases for the dialog header
b4b3923
to
38d2b0a
Compare
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
Looks good |
Please provide a link to the associated issue.
Closes: #6100
Please provide a brief summary of this pull request.
fixing the accessability test cases
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md