fix(core,platform): fixed split button missing class (#8034)

SAP · May 16, 2022 · f9d8c23 · f9d8c23
1 parent ace2ad7
commit f9d8c23
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/libs/core/src/lib/split-button/split-button.component.html b/libs/core/src/lib/split-button/split-button.component.html
@@ -1,5 +1,6 @@
 <div
     class="fd-button-split fd-has-margin-right-small"
+    [ngClass]="typeClass"
     role="group"
     tabindex="-1"
     [attr.aria-label]="arialLabel"

diff --git a/libs/core/src/lib/split-button/split-button.component.scss b/libs/core/src/lib/split-button/split-button.component.scss
@@ -1,9 +1 @@
 @import '~fundamental-styles/dist/button-split';
-
-// Remove after merging https://github.com/SAP/fundamental-styles/issues/2163
-.fd-button-split,
-.fd-button-split > :first-child:hover {
-    .fd-button-split__text {
-        color: inherit;
-    }
-}
diff --git a/libs/core/src/lib/split-button/split-button.component.ts b/libs/core/src/lib/split-button/split-button.component.ts
@@ -133,6 +133,11 @@ export class SplitButtonComponent implements AfterContentInit, OnChanges, OnDest
     /** @hidden */
     mainButtonWidth: string;
 
+    /** @hidden */
+    get typeClass(): string {
+        return this.fdType ? `fd-button-split--${this.fdType}` : '';
+    }
+
     /** @hidden */
     private _menuItemSubscriptions = new Subscription();
 

diff --git a/libs/platform/src/lib/split-menu-button/split-menu-button.component.html b/libs/platform/src/lib/split-menu-button/split-menu-button.component.html
@@ -1,5 +1,6 @@
 <div
     class="fd-button-split"
+    [class]="typeClass"
     role="group"
     aria-label="split-button"
     [attr.dir]="dir"

diff --git a/libs/platform/src/lib/split-menu-button/split-menu-button.component.ts b/libs/platform/src/lib/split-menu-button/split-menu-button.component.ts
@@ -91,6 +91,11 @@ export class SplitMenuButtonComponent extends BaseComponent implements OnInit, A
      * @hidden */
     private _rtlChangeSubscription = Subscription.EMPTY;
 
+    /** @hidden */
+    get typeClass(): string {
+        return this.type ? `fd-button-split--${this.type}` : '';
+    }
+
     constructor(protected _cd: ChangeDetectorRef, @Optional() private _rtlService: RtlService) {
         super(_cd);
     }