Introduce Cloud Logging Exporter #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register signal exporters for logs, metrics and traces, that forward signals to SAP Cloud Logging, if an appropriate service binding is found or do a non operation otherwise. This allows developers to explicitly configure the export, e.g. by `otel.logs.exporter=cloud-logging`. Additional exporters can be added with comma-separated labels. Signed-off-by: Karsten Schnitter <[email protected]>
Adds unit tests for all main parts of the new instrumentation. Checking cases of missing bindings and other configuration issues. Signed-off-by: Karsten Schnitter <[email protected]>
Fixes source id and adds process attributes. Signed-off-by: Karsten Schnitter <[email protected]>
Use the same service binding scanning in old and new exporter configuration. Signed-off-by: Karsten Schnitter <[email protected]>
Add references to the `cloud-logging`exporter to the documentation. Describe the new config properties to control the extension. Signed-off-by: Karsten Schnitter <[email protected]>
KarstenSchnitter
force-pushed
the
otel-cloud-logging
branch
from
6dfc56b
to
e99fb8a
Compare
| return invocation.getArguments()[1]; | ||
| } | ||
| }); | ||
|
|
| return invocation.getArguments()[1]; | ||
| } | ||
| }); | ||
|
|
| return invocation.getArguments()[1]; | ||
| } | ||
| }); | ||
|
|
|
You might want to consider to remove the test resources not needed for the tests |
Delete unnecessary files from key and certificate creation. Signed-off-by: Karsten Schnitter <[email protected]>
| @@ -37,27 +38,76 @@ java -javaagent:BOOT-INF/lib/opentelemetry-javaagent-<version>.jar \ | |||
|
|
|||
| See the [example manifest](../sample-spring-boot/manifest-otel-javaagent.yml), how this translates into a deployment description. | |||
|
|
|||
| For the instrumentation to send observability data to SAP Cloud Logging, the application needs to be bound to a corresponding service instance. | |||
| The service instance can be either managed or [user-provided](#using-user-provided-service-instances). | |||
| Once the agent is attached to the JVM with the ectension in place, there are two ways, which can be used to send data to [SAP Cloud Logging](https://discovery-center.cloud.sap/serviceCatalog/cloud-logging): | |||
There was a problem hiding this comment.
Suggested change
| Once the agent is attached to the JVM with the ectension in place, there are two ways, which can be used to send data to [SAP Cloud Logging](https://discovery-center.cloud.sap/serviceCatalog/cloud-logging): | |
| Once the agent is attached to the JVM with the extension in place, there are two ways, which can be used to send data to [SAP Cloud Logging](https://discovery-center.cloud.sap/serviceCatalog/cloud-logging): |
|
|
||
| Note, that the OpenTelemetry Java Agent currently sends traces and metrics by default using the `otlp` exporter. | ||
| That means, without any configuration the agent with the extension will forward metrics and traces to [SAP Cloud Logging](https://discovery-center.cloud.sap/serviceCatalog/cloud-logging). | ||
| See TODO for the difference between `cloud-logging` and `otlp` exporters. |
| return defaultAggregationSelector.getDefaultAggregation(instrumentType); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
missing new line, also check files below
KarstenSchnitter
added a commit
that referenced
this pull request
Jan 15, 2024
Take over suggestions from #169. Signed-off-by: Karsten Schnitter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom exporter
cloud-loggingthat is fully auto-configured with all available bindings to SAP Cloud Logging.Avoid generation of any local files containing secrets.
This allows to utilize the default
otlpexporter for different data sinks.