Add a new servlet logging module supporting jakarta.* packages. #153
Conversation
|
|
|
I'm not able to sign the CLA, I get this error: |
|
Thanks, for providing this change. I will clarify, what the problem with the CLA is. Members of the SAP Github organisation should have the CLA signed that way. |
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>cf-java-logging-support-servlet</artifactId> | ||
| <version>${project.version}</version> | ||
| <type>jar</type> |
There was a problem hiding this comment.
What is the benefit of building and using a jar compared to accessing the folder directly? The code will always be built together, won't it?
There was a problem hiding this comment.
The benefit is from my point of view, that the maven-dependency-plugin does the job to provide and extract the source code. We don't have to care about the project structure to find the sources and copy them into this module. I assume this can be also done, but I don't know how to do this with maven.
| <goal>jar</goal> | ||
| <goal>test-jar</goal> |
There was a problem hiding this comment.
Will this created more artefacts, that will be uploaded to Maven Central. Note, that in the parent pom.xml, there is the "ossrh" profile, that creates, signs and uploads the artefacts. This already contains a maven-source-plugin. Do you have an idea, how these two configurations interact?
There was a problem hiding this comment.
You could be right, that could really a problem. If you have look into the target folder of this module, it contains 2 additional jars. Can somehow control which artifacts are uploaded to Maven central? Do you have something like an artifact or module list? To be honest I'm not familiar with this upload.
There was a problem hiding this comment.
I tested the publishing. It almost looks fine, but for the jar, that contains the sources. It does not exists, since its execution phase is so early in the Maven lifecycle, that all the actions for providing the correct code come afterwards. I will add the required configuration, once this PR is merged. Without a sources jar, Maven Central would reject this project.
|
@KarstenSchnitter @mofterdinger , Thanks for considering the support for jakarta.* packages. May be i would like to know by when we can expect this change to be available into SAP Internal Artifactory ? Regards, |
|
@Mazhar0910 I am currently clarifying the usage of the additional Maven plugin. This is a prerequisite for a merge of this change. It would be very beneficial if the first Maven build after checkout was succeeded, as well. The build issue I could work-around for now, though. I still have to check, what kind of artefacts will be uploaded to Maven Central. Still, I do not think, these issues will take to long to clarify or mitigate. I estimate a new library version containing this change in early March. |
|
Currently |
|
Hi colleagues, Hi @mofterdinger , please consider my PR: It is using a plugin that needs no extra license checking. |
other plugin for javax to jakarta
|
@aamotharald Thanks for your PR, with your changes the test no longer fail :-). From my point of view it looks good. |
There was a problem hiding this comment.
Thanks @mofterdinger and @aamotharald for the contribution. This looks fine. I will have to do some minor changes to provide a sources jar for the new Jakarta modules. But this does not need to be part of this PR. Currently CLA validation is failing again. @aamotharald can you check, whether your account is connected with the SAP org. I will recheck the status repeatedly and work on the missing jar.
|
Once more, thanks for the contribution. I will go over the dependencies of the entire project and create a new release afterwards. |
The latest version 3.6.3 of
cf-java-logging-support-servletis not compatible with the Jakarta Servlet API. The Jakarta Servlet API is also used by the new Spring Framework 6.This PR adds a new module
cf-java-logging-support-servlet-jakartawhich supports the jakarta servlet API. This PR copies the source and test-source code of modulecf-java-logging-support-servletto the new module. Then it replaces the packagesjavax.*withjakarta.*and performs the tests.