generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use literal string for orchestration models #125
Merged
ZhongpinWang
merged 11 commits into
main
from
feat-use-literal-string-for-orchestration-models
Sep 12, 2024
Merged
feat: Use literal string for orchestration models #125
ZhongpinWang
merged 11 commits into
main
from
feat-use-literal-string-for-orchestration-models
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongpinWang
commented
Sep 10, 2024
marikaner
reviewed
Sep 12, 2024
marikaner
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but I have no concerns.
KavithaSiva
reviewed
Sep 12, 2024
ZhongpinWang
deleted the
feat-use-literal-string-for-orchestration-models
branch
September 12, 2024 13:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/gen-ai-hub-sdk-js-backlog#102.
Model name autocompletion is supported now:
Custom strings are also allowed in case some model has not been included in the list yet.
Model types moved to
@sap-ai-sdk/core
for reuse by bothfoundation-models
andorchestration
packages.Definition of Done