Skip to content

Commit

Permalink
fix: Fix missing and unused dependencies (#155)
Browse files Browse the repository at this point in the history
* fix: Fix dependency issues

* add changeset

* update lockfile

* move up dev deps
  • Loading branch information
marikaner authored Sep 20, 2024
1 parent 1f4880b commit 506a1e4
Show file tree
Hide file tree
Showing 12 changed files with 378 additions and 175 deletions.
12 changes: 12 additions & 0 deletions .changeset/kind-boxes-teach.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
'@sap-ai-sdk/foundation-models': patch
'@sap-ai-sdk/orchestration': patch
'@sap-ai-sdk/langchain': patch
'@sap-ai-sdk/type-tests': patch
'@sap-ai-sdk/ai-api': patch
'@sap-ai-sdk/e2e-tests': patch
'@sap-ai-sdk/core': patch
'@sap-ai-sdk/sample-code': patch
---

[Fixed Issue] Fix missing and unused dependencies.
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"e2e-tests": "pnpm -F=@sap-ai-sdk/e2e-tests",
"type-tests": "pnpm -F=@sap-ai-sdk/type-tests",
"smoke-tests": "pnpm -F=@sap-ai-sdk/smoke-tests",
"check:public-api": "pnpm -r check:public-api"
"check:public-api": "pnpm -r check:public-api",
"check:deps": "pnpm -r -F !./tests/smoke-tests exec depcheck --ignores nock --quiet"
},
"devDependencies": {
"@changesets/cli": "^2.27.8",
Expand All @@ -39,12 +40,13 @@
"@sap-cloud-sdk/eslint-config": "^3.21.0",
"@sap-cloud-sdk/generator-common": "^3.21.0",
"@sap-cloud-sdk/http-client": "^3.21.0",
"@sap-cloud-sdk/util": "^3.21.0",
"@sap-cloud-sdk/openapi-generator": "^3.21.0",
"@sap-cloud-sdk/util": "^3.21.0",
"@types/jest": "^29.5.13",
"@types/jsonwebtoken": "^9.0.7",
"@types/mock-fs": "^4.13.4",
"@types/node": "^20.16.5",
"depcheck": "^1.4.7",
"eslint": "^9.10.0",
"glob": "^11.0.0",
"jest": "^30.0.0-alpha.6",
Expand Down
6 changes: 2 additions & 4 deletions packages/ai-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
"check:public-api": "node --loader ts-node/esm ../../scripts/check-public-api-cli.ts"
},
"dependencies": {
"@sap-ai-sdk/core": "workspace:^"
},
"devDependencies": {
"typescript": "^5.6.2"
"@sap-ai-sdk/core": "workspace:^",
"@sap-cloud-sdk/connectivity": "^3.21.0"
}
}
3 changes: 0 additions & 3 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,5 @@
"@sap-cloud-sdk/http-client": "^3.21.0",
"@sap-cloud-sdk/openapi": "^3.21.0",
"@sap-cloud-sdk/util": "^3.21.0"
},
"devDependencies": {
"typescript": "^5.6.2"
}
}
4 changes: 0 additions & 4 deletions packages/foundation-models/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,11 @@
"dependencies": {
"@sap-ai-sdk/ai-api": "workspace:^",
"@sap-ai-sdk/core": "workspace:^",
"@sap-cloud-sdk/connectivity": "^3.21.0",
"@sap-cloud-sdk/http-client": "^3.21.0",
"@sap-cloud-sdk/openapi": "^3.21.0",
"@sap-cloud-sdk/util": "^3.21.0"
},
"devDependencies": {
"nock": "^13.5.5",
"ts-to-zod": "^3.13.0",
"typescript": "^5.6.2",
"zod": "^3.23.8"
}
}
4 changes: 1 addition & 3 deletions packages/langchain/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,9 @@
},
"dependencies": {
"@sap-ai-sdk/ai-api": "workspace:^",
"@sap-ai-sdk/core": "workspace:^",
"@sap-ai-sdk/foundation-models": "workspace:^",
"@langchain/core": "0.3.3",
"zod-to-json-schema": "^3.23.2"
},
"devDependencies": {
"typescript": "^5.5.4"
}
}
8 changes: 4 additions & 4 deletions packages/langchain/src/openai/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import type {
BaseChatModelParams
} from '@langchain/core/language_models/chat_models';
import { BaseLLMParams } from '@langchain/core/language_models/llms';
import type { AzureOpenAiCreateChatCompletionRequest } from '@sap-ai-sdk/foundation-models';
import type {
AzureOpenAiChatModel,
CustomRequestConfig
} from '@sap-ai-sdk/core';
AzureOpenAiCreateChatCompletionRequest,
AzureOpenAiChatModel
} from '@sap-ai-sdk/foundation-models';
import type { CustomRequestConfig } from '@sap-ai-sdk/core';
import type { ModelConfig, ResourceGroupConfig } from '@sap-ai-sdk/ai-api';

/**
Expand Down
8 changes: 1 addition & 7 deletions packages/orchestration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@
"@sap-ai-sdk/core": "workspace:^",
"@sap-ai-sdk/ai-api": "workspace:^",
"@sap-cloud-sdk/http-client": "^3.21.0",
"@sap-cloud-sdk/connectivity": "^3.21.0",
"@sap-cloud-sdk/util": "^3.21.0",
"@sap-cloud-sdk/openapi": "^3.21.0"
},
"devDependencies": {
"typescript": "^5.6.2",
"nock": "^13.5.5"
"@sap-cloud-sdk/util": "^3.21.0"
}
}
Loading

0 comments on commit 506a1e4

Please sign in to comment.