Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format version to ABAP Object types #258

Merged
merged 7 commits into from
Nov 2, 2021
Merged

Conversation

wurzka
Copy link
Contributor

@wurzka wurzka commented Oct 29, 2021

Closes #237

Component schema/$schema is replaced with format_version/formatVersion

Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the raised issues. Thanks

README.md Outdated Show resolved Hide resolved
docs/json.md Outdated Show resolved Hide resolved
file-formats/chkc/type/zif_aff_chkc_v1.intf.abap Outdated Show resolved Hide resolved
@albertmink albertmink force-pushed the update/formatVersion branch from a81db20 to 0036378 Compare November 2, 2021 07:27
@albertmink albertmink self-requested a review November 2, 2021 07:28
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good to me.

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schneidermic0 schneidermic0 merged commit b0d33a6 into main Nov 2, 2021
@schneidermic0 schneidermic0 deleted the update/formatVersion branch November 2, 2021 08:30
albertmink added a commit that referenced this pull request Nov 2, 2021
* Add format version to ABAP Object types

* Indentation fixed

* Fix Dead Links

* Add Documentation

* Whitespaces

* Apply suggestions from code review; typos

* apply format version type instead of string

Co-authored-by: Albert Mink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt all objects to new versions of JSON Schema
3 participants