Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to type specification #154

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Conversation

schneidermic0
Copy link
Contributor

closes #128

@larshp
Copy link
Collaborator

larshp commented Aug 11, 2021

if there is a definition for REPS(LIMU type), which folder will it be in?

@schneidermic0
Copy link
Contributor Author

schneidermic0 commented Aug 11, 2021

Currently REPS is located in the FUGR folder, because no other type in the repository uses it (yet).
If we reuse it, I suggest to create a REPS folder.

@schneidermic0 schneidermic0 requested review from wurzka and jhunni August 11, 2021 09:40
@larshp
Copy link
Collaborator

larshp commented Aug 11, 2021

we already know REPS is part of PROG

but anyhow, this is where I find things to get difficult, when does things get folders? if looking for something where is it located? if there is both LIMU and R3TR folders, how do I determine which are which?

@schneidermic0
Copy link
Contributor Author

@larshp Before I comment on this, one short question: How would you expect the .abap filename for a program R3TR PROG would look like?

@larshp
Copy link
Collaborator

larshp commented Aug 11, 2021

my suggestion would be zreport.prog.abap, and then put all the metadata(REPT + CUAD + DOCU + DYNP + more?) into a single zreport.prog.json file, alternatively it could have 6+ files,

zfoobar.prog.zfoobar.rept.json
zfoobar.prog.zfoobar.cuad.json
zfoobar.prog.rezfoobar.docu.json
zfoobar.prog.zfoobar2000.dynp.json
zfoobar.prog.json
zfoobar.prog.abap

and/or

zfoobar.prog.zfoobar.rept.json
zfoobar.prog.zfoobar.cuad.json
zfoobar.prog.rezfoobar.docu.json
zfoobar.prog.zfoobar2000.dynp.json
zfoobar.prog.json
zfoobar.prog.zfoobar.reps.json
zfoobar.prog.zfoobar.reps.abap

which is the direction the current FUGR suggestion is moving in

related = #115

@schneidermic0
Copy link
Contributor Author

The current suggestion for FUGR is the multiple-file approach (your 6+ files approach)

I think there is following difference between FUGR and PROG: Each include for a PROG is self-contained object which is stored in TADIR and can only be transported by specifying the include name. For FUGRs, you can transport all includes belonging to the function group (due to naming convention L???; ? = placeholder for a single character) by transport R3TR FUGR. This means the includes in a FUGR a sub objects belonging to the FUGR.
Other includes are standalone includes and might be included in a program, but they do not belong to the program.
This also means includes of a program can be distributed over multiple packages. Includes of function groups can't be distributed in various packages.

Therefore, I think we don't need any REPS relation in programs in the file formats. Here the object type PROG is sufficient. And REPS becomes only a reusable part for function groups, module pools and so on.

Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@schneidermic0
Copy link
Contributor Author

@larshp The discussion above does not hinder us to merge this PR, does it?

@schneidermic0 schneidermic0 added the documentation Improvements or additions to documentation label Aug 12, 2021
@larshp
Copy link
Collaborator

larshp commented Aug 12, 2021

nah, just merge it

@schneidermic0 schneidermic0 merged commit abb27e2 into main Aug 12, 2021
@schneidermic0 schneidermic0 deleted the docu/filenamesForLimu branch August 12, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface file definitions naming
4 participants