-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation to type specification #154
Conversation
if there is a definition for REPS(LIMU type), which folder will it be in? |
Currently REPS is located in the FUGR folder, because no other type in the repository uses it (yet). |
we already know REPS is part of PROG but anyhow, this is where I find things to get difficult, when does things get folders? if looking for something where is it located? if there is both LIMU and R3TR folders, how do I determine which are which? |
@larshp Before I comment on this, one short question: How would you expect the |
my suggestion would be zfoobar.prog.zfoobar.rept.json
zfoobar.prog.zfoobar.cuad.json
zfoobar.prog.rezfoobar.docu.json
zfoobar.prog.zfoobar2000.dynp.json
zfoobar.prog.json
zfoobar.prog.abap and/or zfoobar.prog.zfoobar.rept.json
zfoobar.prog.zfoobar.cuad.json
zfoobar.prog.rezfoobar.docu.json
zfoobar.prog.zfoobar2000.dynp.json
zfoobar.prog.json
zfoobar.prog.zfoobar.reps.json
zfoobar.prog.zfoobar.reps.abap which is the direction the current FUGR suggestion is moving in related = #115 |
The current suggestion for FUGR is the multiple-file approach (your 6+ files approach) I think there is following difference between FUGR and PROG: Each include for a PROG is self-contained object which is stored in TADIR and can only be transported by specifying the include name. For FUGRs, you can transport all includes belonging to the function group (due to naming convention L???; ? = placeholder for a single character) by transport R3TR FUGR. This means the includes in a FUGR a sub objects belonging to the FUGR. Therefore, I think we don't need any REPS relation in programs in the file formats. Here the object type PROG is sufficient. And REPS becomes only a reusable part for function groups, module pools and so on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
@larshp The discussion above does not hinder us to merge this PR, does it? |
nah, just merge it |
closes #128