Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ENHS Type #129

Merged
merged 16 commits into from
Jul 22, 2021
83 changes: 39 additions & 44 deletions file-formats/enhs/enhs.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "http://github.com/SAP/abap-file-formats/file-formats/enhs/enhs.json",
"$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/enhs/enhs.json",
"title": "ENHS Object Type",
"description": "Object type ENHS",
"type": "object",
"properties": {
"$schema": {
Expand All @@ -10,23 +12,23 @@
},
"header": {
"title": "Header",
"description": "Header",
"type": "object",
"properties": {
"description": {
"title": "Description",
"description": "Description of an BAdI Enhancement Spot",
"description": "Description of the ABAP object",
"type": "string",
"maxLength": 255
"maxLength": 100
},
"masterLanguage": {
"title": "Master Language",
"description": "Master language of the BAdI Enhancement Spot\nAll translatable text shall be maintained in this language",
"originalLanguage": {
"title": "Original Language",
"description": "Original language of the ABAP object",
"type": "string",
"minLength": 2,
"maxLength": 2
},
"abapLanguageVersion": {
"title": "Abap Language Version",
"title": "ABAP Language Version",
"description": "ABAP language version",
"type": "string",
"enum": [
Expand All @@ -36,15 +38,15 @@
],
"enumDescriptions": [
"Standard",
wurzka marked this conversation as resolved.
Show resolved Hide resolved
"ABAP for key user tools",
"ABAP for Cloud Development"
"ABAP for key user extensibility",
"ABAP cloud development"
]
}
},
"additionalProperties": false,
"required": [
"description",
"masterLanguage",
"originalLanguage",
"abapLanguageVersion"
]
},
Expand All @@ -66,7 +68,7 @@
"badiDefinition"
],
"enumDescriptions": [
"BAdI Definition"
"BAdI definition"
]
}
},
Expand Down Expand Up @@ -118,7 +120,7 @@
]
},
"multipleUse": {
"title": "Single- or multiple use BAdI",
"title": "Single- or Multiple Use BAdI",
"description": "Indicator whether the BAdI definition is single- or multiple usable",
"type": "boolean"
},
Expand Down Expand Up @@ -150,15 +152,15 @@
"maxLength": 30
},
"filterLimitation": {
"title": "Limited Filter use",
"title": "Limited Filter Use",
"description": "Limited filter use",
"type": "boolean"
},
"documentationId": {
"title": "Documentation Id",
"description": "Documentation Id",
"type": "string",
"maxLength": 30
"maxLength": 60
},
"amdp": {
"title": "Amdp BAdI",
Expand All @@ -171,18 +173,18 @@
"type": "array",
"items": {
"title": "Filter",
"description": "Information about this Filter",
"description": "Information about this filter",
"type": "object",
"properties": {
"name": {
"title": "Name of the Filter",
"description": "Name of the Filter",
"description": "Name of the filter",
"type": "string",
"maxLength": 30
},
"description": {
"title": "Description of the Filter",
"description": "Description of the Filter",
"description": "Description of the filter",
"type": "string",
"maxLength": 255
},
Expand All @@ -191,15 +193,15 @@
"description": "Type of the filter",
"type": "string",
"enum": [
"Integer",
"Character",
"String",
"Numeric",
"Packed"
"integer",
"characterLike",
"string",
"numeric",
"packed"
],
"enumDescriptions": [
"Integer",
"Character",
"Character-like",
"String",
"Numeric",
"Packed"
Expand All @@ -212,26 +214,27 @@
},
"valueCheckDdic": {
"title": "Value Check Ddic",
"description": "Value check via Domain or Data Element",
"description": "Value check via domain or data element",
"type": "object",
"properties": {
"type": {
"title": "Type of the Value Check Object",
"description": "Type of the value check object",
"type": "string",
"enum": [
"Domain",
"DataElement"
"domain",
"dataElement"
],
"enumDescriptions": [
"Domain",
"Data Element"
"Data element"
]
},
"objectName": {
"title": "Name of the Value Check Object",
"description": "Name of the value check object",
"type": "string"
"type": "string",
"maxLength": 30
}
},
"additionalProperties": false,
Expand All @@ -249,17 +252,21 @@
"title": "Name of the Value Check Class",
"description": "Name of the value check class",
"type": "string",
"maxLenght": 30
"maxLength": 30
},
"length": {
"title": "Length of the Value Check",
"description": "Length of the value check",
"type": "number"
"type": "integer",
"minimum": -2147483648,
"maximum": 2147483647
},
"decimalPlaces": {
"title": "Decimal Places of the Value Check",
"description": "Decimal places of the value check",
"type": "number"
"type": "integer",
"minimum": -2147483648,
"maximum": 2147483647
}
},
"additionalProperties": false,
Expand All @@ -277,18 +284,6 @@
}
}
},
"if": {
"properties": {
"useFallbackClass": {
"const": "true"
}
}
},
"then": {
"required": [
"fallbackClass"
]
},
"additionalProperties": false,
"required": [
"name",
Expand Down
31 changes: 0 additions & 31 deletions file-formats/enhs/examples/z_aff_example_enhs.enhs.json

This file was deleted.

Loading