CHKV: add lower than/equals (#302)

SAP · Feb 15, 2022 · fc95c8c · fc95c8c
1 parent 85f3d6a
commit fc95c8c
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 39 deletions.
diff --git a/file-formats/chkv/chkv-v1.json b/file-formats/chkv/chkv-v1.json
@@ -147,7 +147,9 @@
                           "notEqual",
                           "notBetween",
                           "notContainsPattern",
-                          "greaterEqual"
+                          "greaterEqual",
+                          "lessThan",
+                          "lessEqual"
                         ],
                         "enumTitles": [
                           "Equals",
@@ -157,7 +159,9 @@
                           "Not Equal",
                           "Not Between",
                           "Not Contains Pattern",
-                          "Greater Equal"
+                          "Greater Equal",
+                          "Less Than",
+                          "Less Equal"
                         ],
                         "enumDescriptions": [
                           "Equals",
@@ -167,7 +171,9 @@
                           "Not equal",
                           "Not between",
                           "Not contains pattern",
-                          "Greater equal"
+                          "Greater equal",
+                          "Less than",
+                          "Less equal"
                         ]
                       },
                       "low": {

diff --git a/file-formats/chkv/examples/z_aff_example_chkv.chkv.json b/file-formats/chkv/examples/z_aff_example_chkv.chkv.json
@@ -54,7 +54,7 @@
           "valueRangeList": [
             {
               "sign": "exclude",
-              "option": "equals",
+              "option": "lessEqual",
               "low": "P",
               "high": ""
             }

diff --git a/file-formats/chkv/type/zif_aff_chkv_v1.intf.abap b/file-formats/chkv/type/zif_aff_chkv_v1.intf.abap
@@ -1,40 +1,6 @@
 INTERFACE zif_aff_chkv_v1
   PUBLIC.
 
-  "! <p class="shorttext">Option</p>
-  "! Option
-  "! $values {@link zif_aff_chkv_v1.data:co_option}
-  TYPES ty_option TYPE c LENGTH 2.
-
-  CONSTANTS:
-    "! <p class="shorttext">Option</p>
-    "! Option
-    BEGIN OF co_option,
-      "! <p class="shorttext">Equals</p>
-      "! Equals
-      equals               TYPE ty_option VALUE 'EQ',
-      "! <p class="shorttext">Between</p>
-      "! Between
-      between              TYPE ty_option VALUE 'BT',
-      "! <p class="shorttext">Greater Than</p>
-      "! Greater than
-      greater_than         TYPE ty_option VALUE 'GT',
-      "! <p class="shorttext">Contains Pattern</p>
-      "! Contains pattern
-      contains_pattern     TYPE ty_option VALUE 'CP',
-      "! <p class="shorttext">Not Equal</p>
-      "! Not equal
-      not_equal            TYPE ty_option VALUE 'NE',
-      "! <p class="shorttext">Not Between</p>
-      "! Not between
-      not_between          TYPE ty_option VALUE 'NB',
-      "! <p class="shorttext">Not Contains Pattern</p>
-      "! Not contains pattern
-      not_contains_pattern TYPE ty_option VALUE 'NP',
-      "! <p class="shorttext">Greater Equal</p>
-      "! Greater equal
-      greater_equal        TYPE ty_option VALUE 'GE',
-    END OF co_option.
 
   "! <p class="shorttext">Sign</p>
   "! Sign
@@ -64,7 +30,7 @@ INTERFACE zif_aff_chkv_v1
       "! <p class="shorttext">Option</p>
       "! Sign option of the range
       "! $required
-      option TYPE ty_option,
+      option TYPE zif_aff_types_v1=>ty_option,
       "! <p class="shorttext">Low</p>
       "! The low value of the range
       "! $required

diff --git a/file-formats/zif_aff_types_v1.intf.abap b/file-formats/zif_aff_types_v1.intf.abap
@@ -132,4 +132,44 @@ INTERFACE zif_aff_types_v1 PUBLIC.
       description TYPE ty_description_60,
     END OF ty_header_only_description.
 
+  "! <p class="shorttext">Option</p>
+  "! Option
+  "! $values {@link if_aff_types_v1.data:co_option}
+  TYPES ty_option TYPE c LENGTH 2.
+
+  CONSTANTS:
+    "! <p class="shorttext">Option</p>
+    "! Option
+    BEGIN OF co_option,
+      "! <p class="shorttext">Equals</p>
+      "! Equals
+      equals               TYPE ty_option VALUE 'EQ',
+      "! <p class="shorttext">Between</p>
+      "! Between
+      between              TYPE ty_option VALUE 'BT',
+      "! <p class="shorttext">Greater Than</p>
+      "! Greater than
+      greater_than         TYPE ty_option VALUE 'GT',
+      "! <p class="shorttext">Contains Pattern</p>
+      "! Contains pattern
+      contains_pattern     TYPE ty_option VALUE 'CP',
+      "! <p class="shorttext">Not Equal</p>
+      "! Not equal
+      not_equal            TYPE ty_option VALUE 'NE',
+      "! <p class="shorttext">Not Between</p>
+      "! Not between
+      not_between          TYPE ty_option VALUE 'NB',
+      "! <p class="shorttext">Not Contains Pattern</p>
+      "! Not contains pattern
+      not_contains_pattern TYPE ty_option VALUE 'NP',
+      "! <p class="shorttext">Greater Equal</p>
+      "! Greater equal
+      greater_equal        TYPE ty_option VALUE 'GE',
+      "! <p class="shorttext">Less Than</p>
+      "! Less than
+      less_than            TYPE ty_option VALUE 'LT',
+      "! <p class="shorttext">Less Equal</p>
+      "! Less equal
+      less_equal           TYPE ty_option VALUE 'LE',
+    END OF co_option.
 ENDINTERFACE.