refactor INTF (#85)

* refactor INTF * Update file-formats/intf/zif_aff_intf_v1.intf.abap Co-authored-by: Michael Schneider <[email protected]> * Update file-formats/intf/zif_aff_intf_v1.intf.abap Co-authored-by: Michael Schneider <[email protected]> * Update file-formats/intf/zif_aff_intf_v1.intf.abap Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> * Update file-formats/intf/zif_aff_intf_v1.intf.abap Co-authored-by: Michael Schneider <[email protected]> Co-authored-by: Michael Schneider <[email protected]> Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
SAP · May 12, 2021 · 05ef028 · 05ef028
1 parent 37724f7
commit 05ef028
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 28 deletions.
diff --git a/file-formats/intf/zif_aff_intf_v1.intf.abap b/file-formats/intf/zif_aff_intf_v1.intf.abap
@@ -11,32 +11,39 @@ INTERFACE zif_aff_intf_v1 PUBLIC.
     "! Interface component descriptions
     component_descriptions    TYPE SORTED TABLE OF component_description WITH UNIQUE KEY name,
     "! Sub component descriptions (e.g., for parameters or exceptions)
-    subcomponent_descriptions TYPE SORTED TABLE OF component_description WITH UNIQUE KEY name,
+    subcomponent_descriptions TYPE SORTED TABLE OF component_description WITH UNIQUE KEY name.
 
-    "! Method description
-    BEGIN OF method.
-      INCLUDE TYPE component_description.
   TYPES:
+    "! Method description
+    BEGIN OF method,
+      name        TYPE zif_aff_types_v1=>object_name_30,
+      "! Description of the component
+      description TYPE zif_aff_types_v1=>description_60,
       "! Parameter descriptions
       parameters TYPE subcomponent_descriptions,
       "! Exception descriptions
       exceptions TYPE subcomponent_descriptions,
     END OF method,
     "! Method descriptions
-    methods TYPE SORTED TABLE OF method WITH UNIQUE KEY name,
+    methods TYPE SORTED TABLE OF method WITH UNIQUE KEY name.
 
-    "! Event description
-    BEGIN OF event.
-      INCLUDE TYPE component_description.
   TYPES:
+    "! Event description
+    BEGIN OF event,
+      "! Name of the component
+      name        TYPE zif_aff_types_v1=>object_name_30,
+      "! Description of the component
+      description TYPE zif_aff_types_v1=>description_60,
       "! Parameter descriptions
       parameters TYPE subcomponent_descriptions,
     END OF event,
     "! Event descriptions
-    events TYPE SORTED TABLE OF event WITH UNIQUE KEY name,
+    events TYPE SORTED TABLE OF event WITH UNIQUE KEY name.
 
-    "! Interface properties content
-    BEGIN OF content,
+  TYPES:
+    "! Interface properties
+    BEGIN OF main,
+      header TYPE zif_aff_types_v1=>head-header,
       "! Type descriptions
       types      TYPE component_descriptions,
       "! Attribute descriptions
@@ -45,13 +52,6 @@ INTERFACE zif_aff_intf_v1 PUBLIC.
       events     TYPE events,
       "! Method descriptions
       methods    TYPE methods,
-    END OF content,
-
-    "! Interface properties
-    BEGIN OF main.
-      INCLUDE TYPE zif_aff_types_v1=>head.
-      INCLUDE TYPE content.
-  TYPES:
     END OF main.
 
-ENDINTERFACE.
+ENDINTERFACE.
diff --git a/file-formats/intf/zif_aff_types_v1.intf.abap b/file-formats/intf/zif_aff_types_v1.intf.abap
@@ -1,8 +1,7 @@
 INTERFACE zif_aff_types_v1 PUBLIC.
 
-  TYPES:
-    "! Language
-    language TYPE c LENGTH 2.
+  "! Language
+  TYPES language TYPE c LENGTH 2.
 
   TYPES:
     "! ABAP language version
@@ -29,12 +28,10 @@ INTERFACE zif_aff_types_v1 PUBLIC.
       END OF header,
     END OF head.
 
-  TYPES:
-    "! Description with 60 characters
-    description_60    TYPE c LENGTH 60.
+  "! Description with 60 characters
+  TYPES description_60 TYPE c LENGTH 60.
 
-  TYPES:
-    "! Object name with max. length 30
-    object_name_30 TYPE c LENGTH 30.
+  "! Object name with max. length 30
+  TYPES object_name_30 TYPE c LENGTH 30.
 
 ENDINTERFACE.