Warning for non required components of type enum without default #168
+29
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like that the JSON Schema tells the default value. I just wonder what this change means to (all) JSON Schema/Interface types from the AFF repository. Do we need to update all AFF type definitions an JSON Schema? |
|
I checked the types that are actually in the AFF repository and created this issue SAP/abap-file-formats#396. There are (hopefully) all types listed that need an adaption. |
|
LGTM. Changes in AFF are compatible, so let's improve this |
albertmink
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #150
So far, it was checked if enum valued components have a possible initial (ABAP) value, are required or have a default. If not, we wrote a warning.
Now, having an initial value is not enough anymore.