reintroduce CDX LSP #6
Conversation
|
|
|
@amiramw @manwithafox please review. I am not sure about the launcher paths in language_server_node_cdx.yml |
| version: 0.0.+ | ||
| repository_root: "https://buildpackcomponentrepositorycdx.cfapps.sap.hana.ondemand.com" | ||
| version: 1.*.* | ||
| repository_root: "https://lsp-component-cds.cfapps.eu10.hana.ondemand.com/" | ||
| env: | ||
| workdir: language_server_node_cdx/ |
There was a problem hiding this comment.
Where does that workdir come from? I don't see it in our lsp.zip inside of the app.
There was a problem hiding this comment.
ahh, I see: resources dir of the buildpack
| version: 0.0.+ | ||
| repository_root: "https://buildpackcomponentrepositorycdx.cfapps.sap.hana.ondemand.com" | ||
| version: 1.*.* | ||
| repository_root: "https://lsp-component-cds.cfapps.eu10.hana.ondemand.com/" | ||
| env: | ||
| workdir: language_server_node_cdx/ | ||
| exec: language_server_node_cdx/launcher.sh |
There was a problem hiding this comment.
same for the launcher.sh -- is this a framework thing?
| exec npm start | ||
| echo 'Starting server.js using node...' >launcher.log | ||
| ./link_logs.sh &>/dev/null </dev/null & | ||
| exec ./nodejs/bin/node ./src/server.js --stdio --strict-code-completion |
There was a problem hiding this comment.
would nodejs be found like that? or would it be better to push this invocation down into the "start" script of our lsp.zip?
There was a problem hiding this comment.
Executing node or npm (or trying to locate it via 'which') in the ssh console does not find it. So I guess this is a contract that node is located at ./nodejs/bin/node i.e. starting it via npm start will also not improve things.
The link_logs.sh was a try out but did never work (=>remove). Guess we have no permission to write something in the ~/logs directory. Nevermind. Would be interesting if the LSP infrastructure does support telemetry/event request. Log file is currently reset upon restart of LS.
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
| rm ~/logs/cdx.log | |||
| echo '' >~/app/.java-buildpack/language_server_node_cdx/cdx_lsp_server.log | |||
|
|
||
| exec npm start | ||
| echo 'Starting server.js using node...' >launcher.log | ||
| ./link_logs.sh &>/dev/null </dev/null & |
| version: 0.0.+ | ||
| repository_root: "https://buildpackcomponentrepositorycdx.cfapps.sap.hana.ondemand.com" | ||
| version: 1.*.* | ||
| repository_root: "https://lsp-component-cds.cfapps.eu10.hana.ondemand.com/" | ||
| env: | ||
| workdir: language_server_node_cdx/ |
There was a problem hiding this comment.
Change section below - we are now using stdio instead of sockets:
ipc:
protocol: "stream"
* Update deploy buildpack job URL. * Update launcher.sh for jdt 0.18.0 (#26)
No description provided.