Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to uv python tool #579

Open
wants to merge 12 commits into
base: jeremy/refactor-dockerfiles
Choose a base branch
from

Conversation

jeremyestein
Copy link
Contributor

@jeremyestein jeremyestein commented Dec 16, 2024

Description

Fixes #{issue_number}: A few words or sentences describing the changes proposed in this pull request (PR).

Known TODOs:

  • documentation still refers to pip
  • explicitly copying all pyproject.toml files in the Dockerfiles is a bit ugly, but can't find a better way
  • The base branch needs some work (see PR comment)
  • uv sync --all-extras --all-packages is currently needed to get pytest. I'd expect just extras to be needed. Do I need to add extras section to root pyproject and link to workspace extras?
  • Do we need a mechanism to ensure that changes to pyproject.toml files are reflected in the uv.lock file so it can be committed too?
  • Why do we need to specify setuptools in pixl_dcmd just for the sake of pydicom? Shouldn't it be responsible for its own dependencies?
  • Do we need to make use of dependency groups?

Type of change

Please delete options accordingly to the description.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Suggested Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have passed on my local host device. (see further details at the CONTRIBUTING document)
  • Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
  • I have requested review to this PR.
  • I have addressed and marked as resolved all the review comments in my PR.
  • Finally, I have selected squash and merge

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (98fa689) to head (e44d4be).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           jeremy/refactor-dockerfiles     #579      +/-   ##
===============================================================
+ Coverage                        85.17%   87.38%   +2.21%     
===============================================================
  Files                               72       76       +4     
  Lines                             3116     3386     +270     
===============================================================
+ Hits                              2654     2959     +305     
+ Misses                             462      427      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremyestein jeremyestein changed the base branch from main to jeremy/refactor-dockerfiles December 21, 2024 12:33
@jeremyestein jeremyestein marked this pull request as ready for review December 21, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant