-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for DESPIAD project #572
base: main
Are you sure you want to change the base?
Conversation
this is because resources sharing the same StudyInstanceUID in Orthanc Raw will be combined into a single resource in Orthanc Anon. Previously, we would try to export each resource after anonymisation, but this meant other resources sharing the same StudyInstanceUID were not exported.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 87.28% 78.76% -8.53%
==========================================
Files 76 59 -17
Lines 3390 2802 -588
==========================================
- Hits 2959 2207 -752
- Misses 431 595 +164 ☔ View full report in Codecov by Sentry. |
04532e7
to
5a47136
Compare
784da58
to
28f92a6
Compare
project: | ||
name: "despiad" | ||
modalities: | ||
- "CT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with CT AFAIK there's some extra fun parts which have burned in data. I think to avoid this we may want to have:
- Minimum instances in a series. At the project level can configure minimum instances in series so that we can filter out a single screenshot that may well still have the
CT
modality - Series filter at a manufacturer level in the project conifg. This is because certain series numbers can always have burned in data - Worth asking John Watts about an example of this
- Related, but to have an allowed manufacturer regex list in the config. So that you filter out manufacturers which you don't know you can handle - in case there's more burned in data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've add these three new options to the project config. The only one I'm not sure about is the series number filter at the manufacturer level. Currently, I've added it at the project level, but do you mean we should be able to specify that the filter is only applied to DICOM from a specified manufacturer? Would something like this make sense:
manufacturer_filters:
- <manufacturer>:
- series_number: [<series number(s) to filter>]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh fun! Yeah they sound like good ideas. Have you ever used something like deid or presidio to remove burned in data?
oh whoops I missed this. Nah haven't tried using them but that could be useful for areas that we know we want to redact specifically. Would be concerned about running them wholesale on all images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think have the allowed manufacturers in the filter perhaps. so like this maybe?
manufacturer_filters:
- regex: ^siemens # defaults to blank, so all manufacturers would be skipped.
exclude_series_numbers: [<series number(s) to filter>] # defaults to empty list
- regex: ^philips
exclude_series_numbers: [<series number(s) to filter>]
In orthanc anon plugin, skip series that have few than min_instances_per_series instances
Description
Closes #571
Closes #530
ensure all resources sharing aThis has already been fixed in Improve anon logging and anonymise all matching studies at once #582StudyInstanceUID
in Orthanc Raw are exported (they may exist as separate resources in Orthanc Raw if they have differentStudyID
s, but are combined into a single resource in Orthanc Anon as theStudyID
tag is deleted)Type of change
Please delete options accordingly to the description.
Suggested Checklist
main
branch.squash and merge