Don't expose ports on all interfaces unless needed #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where no external access (eg from the DSD) is required.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 79 79
Lines 3259 3259
=======================================
Hits 2704 2704
Misses 555 555 ☔ View full report in Codecov by Sentry. |
stefpiatek
approved these changes
May 2, 2024
Co-authored-by: Stef Piatek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #239 (fixing rather than auditing)
Most open ports only need to be accessed from the CLI that's running on the same host. So only listen on localhost.
Similar principal applies to running tests, although those usually won't be run in the hospital.
Orthanc raw and anon are a notable exception as someone may want to view those from the DSD or another hospital computer, but otherwise exposing everything to (perhaps) the whole hospital is a security hazard.