Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big total package size #116

Closed
dsyme opened this issue Jun 16, 2017 · 9 comments
Closed

Big total package size #116

dsyme opened this issue Jun 16, 2017 · 9 comments

Comments

@dsyme
Copy link
Contributor

dsyme commented Jun 16, 2017

The total package size download is big - ~600MB under packages

Repro steps

Build and measure size of "packages" directory

Expected behavior

Less package

Actual behavior

Lotsa package

@dsyme
Copy link
Contributor Author

dsyme commented Jun 16, 2017

Perhaps paket.dependencies could have

framework: auto-detect

Adding that seemed to reduce total package size to 400MB however the build then failed with

image

@forki
Copy link
Member

forki commented Jun 17, 2017

I think autodetect doesn't work with .NET SDK yet. @matthid or does it?

but even then: we have fable, .NET Core and .NET full projects so it would basically be "give me everything" again.

@matthid
Copy link
Contributor

matthid commented Jun 17, 2017

Yes, I did not touch that, but I still vote for getting rid of the packages folder :/

@forki
Copy link
Member

forki commented Jun 17, 2017 via email

@matthid
Copy link
Contributor

matthid commented Jun 17, 2017

For this particular issue it might make sense to first try and figure out what paket should not have downloaded and WHY. I cannot know because I still have not done much fable jet ;)

@alfonsogarciacaro
Copy link
Collaborator

Tell me about it, Fable "packages" folder is more than 1GB (half of it is the docs group) and I believe we don't have many dependencies ;)

Fable 1.x projects usually target netstandard so they should be able to share FSharp.Core with the server project (FSharp.Net.SDK will go away with dotnet sdk 2). Also Fable.XXX packages seem to take less than 10MB in total so I don't think the problem is there.

I guess having multiple groups make the size grow quickly as some things like FSharp.Core have to be downloaded multiple times. The System.XXX packages take around 350 MB (for the main group only), hopefully this also improves with dotnet sdk 2.

I'm all for reducing the size of the packages folder. I have a 256GB also with a Windows partition and I constantly have to delete cloned projects to make space. Having file links would be super nice, but I think Fable could also cope with the .nuget cache, as the location can be taken from the .fsproj.nuget.g.props as @enricosada pointed out, and the version of the packages from the .fsproj.references file.

@alfonsogarciacaro
Copy link
Collaborator

alfonsogarciacaro commented Aug 24, 2017

Related fsprojects/Paket#2650

Closing as this is more an issue of Paket, netstandard dependencies, etc. than this repo.

@alfonsogarciacaro
Copy link
Collaborator

Reopening, I'll update the repo so it uses new Paket storage:none feature 🎉

@alfonsogarciacaro
Copy link
Collaborator

With latest Fable version and Paket storage:none, the size of packages folder has been reduced to around 100MB :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants