Skip to content

Commit

Permalink
libgtop: fix do_compile error
Browse files Browse the repository at this point in the history
On some distros, such as fedora32, cross compile failed with following
error since host library is used. undefined reference to
`stat64@GLIBC_2.33'

According doc of ld, set searchdir begins with "=", but not hardcoded
locations.

Signed-off-by: Changqing Li <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
(cherry picked from commit a6d1ddf)
Signed-off-by: Armin Kuster <[email protected]>
  • Loading branch information
sandy-lcq authored and akuster committed May 23, 2021
1 parent 280a7a1 commit 9ee0e08
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
From e865a93000913b4597607289356114cd159f4e28 Mon Sep 17 00:00:00 2001
From: Your Name <[email protected]>
Date: Fri, 21 May 2021 03:02:29 +0000
Subject: [PATCH] fix compile error for cross compile

On some distros, such as fedora32, cross compile failed with following
error since host library is used. undefined reference to
`stat64@GLIBC_2.33'

According doc of ld, set searchdir begins with "=", but not hardcoded
locations.

Upstream-Status: Submitted [https://gitlab.gnome.org/GNOME/libgtop/-/merge_requests/26]

Signed-off-by: Changqing Li <[email protected]>
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 472f44b..ed6a4d7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -270,8 +270,8 @@ AC_ARG_ENABLE(fatal-warnings,
[Define to enable fatal warnings]))

dnl These definitions are expanded in make.
-LIBGTOP_LIBS='-L$(libdir)'
-LIBGTOP_INCS='-I$(includedir)/libgtop-2.0'
+LIBGTOP_LIBS='-L=$(libdir)'
+LIBGTOP_INCS='-I=$(includedir)/libgtop-2.0'

if test x$libgtop_have_sysinfo = xyes ; then
LIBGTOP_INCS="$LIBGTOP_INCS -DHAVE_LIBGTOP_SYSINFO"
--
2.26.2

2 changes: 2 additions & 0 deletions meta-gnome/recipes-gnome/libgtop/libgtop_2.40.0.bb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ inherit gnomebase lib_package gtk-doc gobject-introspection gettext upstream-ver
inherit features_check
REQUIRED_DISTRO_FEATURES = "x11"

SRC_URI += "file://0001-fix-compile-error-for-cross-compile.patch"

SRC_URI[archive.sha256sum] = "78f3274c0c79c434c03655c1b35edf7b95ec0421430897fb1345a98a265ed2d4"

DEPENDS = "glib-2.0 libxau"

0 comments on commit 9ee0e08

Please sign in to comment.