-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support circular dependencies #27
Comments
It looks like it might still not completely work (at least for the repository I tested it with - ethroulette). Steps to reproduce: git clone [email protected]:rkalis/ethroulette.git && cd ethroulette
npm i -g [email protected]
sol-merger "./contract/Roulette.sol" It then gets stuck. The repo has a UML diagram of the structure of the Roulette contracts, but basically |
@rkalis I found the issue and it is not about circular dependencies, so I'll fix it asap. |
Oh awesome! Thanks for looking into it. I'd just assumed it was due to circular dependencies. Thanks for fixing the issues! |
Several people reported issues with circular dependencies on truffle-plugin-verify (#14, #17). It appears that sol-merger gets stuck in an infinite loop and runs out of memory eventually. @nklipa13 added a very small example that shows this in truffle-plugin-verify#14. I believe @ferittuncer also has more complex contract examples.
The text was updated successfully, but these errors were encountered: