-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support built-in scripts #3
Comments
Looks like your problem is deeper than that though. Is your script really called "Control.tscn::1"? Because that's what the message says it modified. |
cuz its a built-in script, currently it seems not to support built-in, so only works with external scripts |
Ah I'll have to do some research about built-in scripts. Never heard of
that feature before!
…-- Ryan
On Thu, Apr 9, 2020 at 10:40 AM nonunknown ***@***.***> wrote:
cuz its a built-in script, currently it seems not to support built-in, so
only works with external scripts
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKSD7JHYXJCEIZIZTXG6TRLXM5LANCNFSM4MEWK2LQ>
.
|
Thy are Just scripts Just instead of .gd Thy are Inside of .tscn files
Em qui, 9 de abr de 2020 12:57, Ryan Badour <[email protected]>
escreveu:
… Ah I'll have to do some research about built-in scripts. Never heard of
that feature before!
-- Ryan
On Thu, Apr 9, 2020 at 10:40 AM nonunknown ***@***.***>
wrote:
> cuz its a built-in script, currently it seems not to support built-in, so
> only works with external scripts
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#3 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AACKSD7JHYXJCEIZIZTXG6TRLXM5LANCNFSM4MEWK2LQ
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOA6OZVCC4CJHY2GORMERR3RLXREJANCNFSM4MEWK2LQ>
.
|
If you view the file outside of Godot (say with Notepad, Vim, or some other IDE). Do you see the code added correctly? |
I'll check
Em qui, 9 de abr de 2020 14:09, Ryan Badour <[email protected]>
escreveu:
… If you view the file outside of Godot (say with Notepad, Vim, or some
other IDE). Do you see the code added correctly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOA6OZTPEPIIZ3RQ36MZZULRLX6K7ANCNFSM4MEWK2LQ>
.
|
Interesting, but I was curious if the modification to the file worked? I
mean it should fail if it didn't find the _ready function or the extends
line so it must have worked. If refocusing Godot didn't work though I'm not
sure what we can do.
…On Thu, Apr 9, 2020, 2:51 PM nonunknown ***@***.***> wrote:
@Rybadour <https://github.com/Rybadour>
[image: trial]
<https://user-images.githubusercontent.com/58845030/78925228-83d6b180-7a71-11ea-8f48-e2a210b251f3.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKSDZEOYJ3OO6Y5MORRYTRLYDJTANCNFSM4MEWK2LQ>
.
|
FYI: I tried to use my plugin with a basic scene using a built-in script and it didn't work. I'm updating this issue to be about adding support for built-in scripts as it's not just about them not updating. The plugin cannot currently support them. |
Remember that builtin scenes Onlyupdates when reloading the scene
Em sex, 10 de abr de 2020 11:20, Ryan Badour <[email protected]>
escreveu:
… FYI: I tried to use my plugin with a basic scene using a built-in script
and it didn't work. I'm updating this issue to be about adding support for
built-in scripts as it's not just about them not updating. The plugin
cannot currently support them.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOA6OZRS3MS56QII4E2PNXDRL4TKHANCNFSM4MEWK2LQ>
.
|
Fixed! I added support for built-in scripts in the last commit. |
I'm clicking at connect nodes, and cannot see changes, unfocus would be close and reopen the engine?
Using a built-in script!
edit
Closing and reopening godot worked, but only for non-built-in script, if using built-in the closing/opening does not work
maybe is related to this issue: godotengine/godot#10946
The text was updated successfully, but these errors were encountered: