Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support built-in scripts #3

Closed
nonunknown opened this issue Apr 9, 2020 · 11 comments
Closed

[Feature] Support built-in scripts #3

nonunknown opened this issue Apr 9, 2020 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@nonunknown
Copy link
Contributor

nonunknown commented Apr 9, 2020

I'm clicking at connect nodes, and cannot see changes, unfocus would be close and reopen the engine?

Screenshot from 2020-04-09 09-38-55

Using a built-in script!
Screenshot from 2020-04-09 09-40-36

edit

Closing and reopening godot worked, but only for non-built-in script, if using built-in the closing/opening does not work

maybe is related to this issue: godotengine/godot#10946

@Rybadour
Copy link
Owner

Rybadour commented Apr 9, 2020

Looks like your problem is deeper than that though. Is your script really called "Control.tscn::1"? Because that's what the message says it modified.

@nonunknown
Copy link
Contributor Author

cuz its a built-in script, currently it seems not to support built-in, so only works with external scripts

@Rybadour
Copy link
Owner

Rybadour commented Apr 9, 2020 via email

@nonunknown
Copy link
Contributor Author

nonunknown commented Apr 9, 2020 via email

@Rybadour
Copy link
Owner

Rybadour commented Apr 9, 2020

If you view the file outside of Godot (say with Notepad, Vim, or some other IDE). Do you see the code added correctly?

@nonunknown
Copy link
Contributor Author

nonunknown commented Apr 9, 2020 via email

@nonunknown
Copy link
Contributor Author

@Rybadour

trial

@Rybadour
Copy link
Owner

Rybadour commented Apr 9, 2020 via email

@Rybadour Rybadour changed the title [Bug] unfocus not working [Bug] Unfocus not updating a built-in script Apr 10, 2020
@Rybadour
Copy link
Owner

FYI: I tried to use my plugin with a basic scene using a built-in script and it didn't work. I'm updating this issue to be about adding support for built-in scripts as it's not just about them not updating. The plugin cannot currently support them.

@Rybadour Rybadour added the enhancement New feature or request label Apr 10, 2020
@Rybadour Rybadour changed the title [Bug] Unfocus not updating a built-in script [Feature] Support built-in scripts Apr 10, 2020
@nonunknown
Copy link
Contributor Author

nonunknown commented Apr 10, 2020 via email

@Rybadour Rybadour self-assigned this Apr 12, 2020
@Rybadour
Copy link
Owner

Fixed! I added support for built-in scripts in the last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants