Add more e2e tests #106
Merged
Add more e2e tests #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
RyanClementsHax
commented
Oct 30, 2023
•
RyanClementsHax
commented
- add more e2e tests
- update look of test repo
- refactor test repo to work with the concept of a "theme node" to allow for tests with multiple themes to be written
- reuse tmp dirs between playwright projects for performance boost
- retry start command on port assignment failures
- refactor out logic of interacting with a particular themed node on the test repo page into its own class in preparation for tests that test multiple themes simultaneously - setup test repo to allow for easy local development by adding a dummy test config in repo - make the test repo look prettier
|
|
- write a test for multiple themes enabled at the same time - refactor test repo to look nicer - refactor TestNodeImpl to scope its queries to the single node
…urged - put classes generated in tests in the tailwind config's safelist to prevent purging - remove emoji from test repo as that was causing some flakiness in tests
- since there isn't any browser specific code in tests, tmp dirs can be reused to avoid rebuilding the test repo again
- write a test for what should happen if multiple themes enabled on the same node - write a test asserting a theme can't be enabled using the theme name as a class if selectors is set to [] - make temp dirs easier to read - allow for multiple servers to be started per test
RyanClementsHax
commented
Nov 1, 2023
RyanClementsHax
commented
Nov 1, 2023
- use "repo instance" nomenclature to better communicate what it is since multiple of them can be created per int test
|
https://github.com/lint-staged/lint-staged/pull/1117/files consider using |
- before, processes were being leaked every run because only the process that spawned the commands was killed, not the actual processes for the commands - now, this kills all of the processes
- write e2e test for nested theme overriding - update test repo to allow for nested theme nodes - update snapshots
|
🎉 This PR is included in version 3.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.