Broken with css-loader >= 6.0.0

[volkyeth]

Describe the bug

Due to this breaking change on css-loader 6.0.0:

for url and import options Function type was removed in favor Object type with the filter property, i.e. before { url: () => true }, now { url: { filter: () => true } } and before { import: () => true }, now { import: { filter: () => true } }

And due to the the version constraint ^6.5.1 the addon is broken because of current css-loader config that uses old format

requiring [email protected] (before the breaking changes) is a workaround

Your minimal, reproducible example

the repo examples should all be failing on storybook start 🤔

Steps to reproduce

install with css-loader >6.0.0

Expected behavior

storybook should start

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

macOs

storybook-addon-next version

1.4.2

Additional context

No response

[RyanClementsHax]

Hi! Thanks for opening this issue.

I'm having trouble recreating the issue. All of the examples work just fine for me. Could you create a minimal reproduction example?

It might help to know that I recently found out that because of some package resolutions that storybook has, the version of css loader that's actually resolved is v3.x. This leads me to ask the following question: is this a bug that in theory should happen, or is this something you're actually seeing?

Btw, I agree, it's totally expected to think that this addon should break given the info you just gave.

[volkyeth]

Ok, this is more complex than I thought at first. The issue is surfaced in my project by a workaround to #23 that is using "nohoist" on the yarn workspace to keep the node_modules of storybook-addon-next on the same folder it's used, like so:

Doing this decouples the versions of css-loader required by other dependencies from the one required by storybook-addon-next ([email protected]), making the error I reported manifest.

I would still say this is a bug, despite manifesting only in specific circumstances, because storybook-addon-next is incorrectly reporting it supports css-loader >= 6.0.0, so if the other dependencies upgraded their css-loader version this package would break in regular scenarios too.

I'm still trying to setup a minimal reproduction scenario based on the one I created for #23, but it's becoming a nightmare because it seems the upstream storybook packages don't bode well with yarn workspaces too :/

[RyanClementsHax]

So turns out css-loader isn't even needed as a dependency so removing the dependency altogether should work for you right?

See #25

[RyanClementsHax]

@volkyeth I'm pretty much good to go with your solution in #24. I'm just wondering if updating the examples' yarn.lock files would be a nice sanity check to make sure everything installs properly (I've been bitten by package resolution errors one too many times)

[github-actions]

🎉 This issue has been resolved in version 1.6.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀