feat: Restructure for better support and maintenance #46
Conversation
rynecheow
force-pushed
the
feat/v2.0.0
branch
2 times, most recently
from
19d0223
to
46fd4b8
Compare
BREAKING CHANGE: - Moved circleci to githubci - Supports RxSwift 6.0 - Release xcframeworks
|
It seems that the builds are failing. Do you like to fix this as well? |
|
Hi, this PR moves the pipeline to GitHub CI - hence the build on Circle will fail. It'll take some work if we were to fix Circle's pipe. |
|
Can you maybe elaborate what the hell did you do here? You moved every inch of the package 😄 (no offense) but what exactly was the motivation about this? |
|
I think Ryne has a bunch of automatons and stuff he uses for his community projects in RxSwiftCommunity, but I agree this is a really gigantic PR which makes it hard to review. @rynecheow I'm wondering if there's any way to break these changes into smaller consumable PRs (For example, adding Danger and Swiftformat, other changes), or must everything go in a single one ? |
|
@mRs- Am first of all sorry about the gigantic PR! Every change is kinda tied to one another but yes, I can help to break this up into smaller commits, if we need to break up the PR, but unravelling the changes might take me some time, and I hope I can find some time to do that over the next month. What I can probably do is break into several commits from the same change, in the same PR, so that it is clearer what was done, and also change Circle's CI file to at least pass the current change and remove it later. |
|
I'm going through it next week to get this done as fast as possible. |
Non-functional changes
(The above changes were made similar to RxAlamofire & RxRealm)
Breaking changes