ecdsa: refactor prehash_to_field_bytes to bits2field free func
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the verbosely named `prehash_to_field_bytes` from the `DigestPrimitive` trait, chaning it to a `bits2field` free function which has a `C: PrimeCurve` generic parameter. The name is inspired by `bits2int` from RFC6979, however it does not perform a reduction step.
tarcieri
force-pushed
the
ecdsa/refactor-bits2field
branch
from
b93285b
to
a7ef3ca
Compare
Merged
sorah
added a commit
to sorah/needroleshere
that referenced
this pull request
Nov 4, 2023
Resolve incompatibilities as follows: - src/certificate.rs: RustCrypto/formats#771 - src/cmd/serve.rs: Move to FromRequestParts and use headers crate - src/ecdsa_sha256.rs: RustCrypto/traits#1196 and RustCrypto/signatures#574 - src/error.rs: Remove Duplicates - src/identity.rs: Remove owned validation logic as it should be done at x509_cert::serial_number::SerialNumber<x509_cert::certificate::Rfc5280> - src/sign.rs: RustCrypto/RSA#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the verbosely named
prehash_to_field_bytesfrom theDigestPrimitivetrait, chaning it to abits2fieldfree function which has aC: PrimeCurvegeneric parameter.The name is inspired by
bits2intfrom RFC6979, however it does not perform a reduction step.