blake2: x86 coresimd #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacement for simd + simd_opt. Builds on stable rustc 1.27+ The coresimd feature overrides all other simd flags. Build with coresimd will fail for unsupported target platforms, e.g. non-x86. Benched on a Xeon X5650: sse2 only: faster than simd_opt ssse3: slightly faster than simd_opt Benched on a Haswell: avx2: same speed as simd_opt
|
Thank you! You can introduce a separate line for CI like was done for testing AES-NI. I will try to review both of your blake2 PRs on this weekend. |
This will test the sse2 and probably ssse3 coresimd implementations. If the buildbox happens to support avx2, it will also test the avx2 implementations.
|
@kazcw are you interested in continuing to work on this PR, and if so, can you rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #56
Replacement for simd + simd_opt features. Builds on stable rustc 1.27+
The coresimd feature overrides all other simd flags. Build with coresimd will fail for unsupported target platforms, e.g. non-x86.
Benched on a Xeon X5650:
sse2 only: faster than simd_opt
ssse3: slightly faster than simd_opt
Benched on a Haswell:
avx2: same speed as simd_opt
NB. the standard CI settings won't test this properly since it introduces a new feature