der
: Make zeroize
's alloc
feature conditional
#920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
zeroize
'salloc
feature would be enabled ifzeroize
was enabled inder
. Nowzeroize
'salloc
feature is only enabled if thisder
'salloc
feature is enabled.We were hoping to use p256 in a no-alloc environment. Moving p256 from 0.12.0->0.13.0 results in
alloc
getting pulled in.It looks like when
sec1
went from 0.3.0->0.7.1, sec1/v0.3.0...sec1/v0.7.1#diff-fe7c93733c51ed30397c61754e6d22958291335b1d61470ce78edcdf49a09399R36 itsder
dependency now useszeroize
. Thezeroize
dependency inder
was calling outalloc
.Looking through
der
andsec1
it seems thatalloc
+zerioze
is only needed forder
's document.rs.Making this proposed change may be a breaking change as
der
exposeszeroize
, https://github.com/RustCrypto/formats/blob/master/der/src/lib.rs#L394. If someone was using the Vec, String, etc features exposed viader::zeroize
and thealloc
feature.