der: enable arithmetic and casting clippy lints #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the following lints globally: - `clippy::cast_lossless` - `clippy::cast_possible_truncation` - `clippy::cast_possible_wrap` - `clippy::cast_precision_loss` - `clippy::cast_sign_loss` - `clippy::checked_conversions` - `clippy::implicit_saturating_sub` - `clippy::integer_arithmetic` Some code related to datetime-handling and ASN.1 REAL has been grandfathered in and allows these lints, although it's been labeled with TODOs to convert it to checked arithmetic.
tarcieri
force-pushed
the
der/arithmetic-and-casting-clippy-lints
branch
from
f1e1884 to
97607e1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the following lints globally:
clippy::cast_losslessclippy::cast_possible_truncationclippy::cast_possible_wrapclippy::cast_precision_lossclippy::cast_sign_lossclippy::checked_conversionsclippy::implicit_saturating_subclippy::integer_arithmeticSome code related to datetime-handling and ASN.1 REAL has been grandfathered in and allows these lints, although it's been labeled with TODOs to convert it to checked arithmetic.