der: add Decode and Encode impls for PhantomData
#1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Apr 18, 2023
Comment on lines
+271
to
+272
| /// Test handling of PhantomData. | ||
| pub phantom: PhantomData<()>, |
There was a problem hiding this comment.
Added this as a spot check. It seems to work?
Allows `PhantomData` fields to be used with custom derive
tarcieri
force-pushed
the
der/phantomdata-decode-and-encode-impls
branch
from
993e442 to
6476307
Compare
baloo
added a commit
to baloo/formats
that referenced
this pull request
Apr 18, 2023
similar to RustCrypto#1009, provide a `der::DerOrd` and a `der::ValueOrd` noop implementation for PhantomData
tarcieri
pushed a commit
that referenced
this pull request
Apr 18, 2023
similar to #1009, provide a `der::DerOrd` and a `der::ValueOrd` noop implementation for PhantomData
baloo
added a commit
to baloo/formats
that referenced
this pull request
Apr 19, 2023
- `Decode` and `Encode` impls for `PhantomData` (RustCrypto#1009) - `ValueOrd` and `DerOrd` impls for `PhantomData` (RustCrypto#1012) - Bump `hex-literal` dependency to v0.4.1 (RustCrypto#999) - Bump `der_derive` dependency to v0.7.1 (RustCrypto#1016)
baloo
added a commit
to baloo/formats
that referenced
this pull request
Apr 19, 2023
Added - `Decode` and `Encode` impls for `PhantomData` (RustCrypto#1009) - `ValueOrd` and `DerOrd` impls for `PhantomData` (RustCrypto#1012) Changed - Bump `hex-literal` dependency to v0.4.1 (RustCrypto#999) - Bump `der_derive` dependency to v0.7.1 (RustCrypto#1016)
Merged
baloo
added a commit
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
PhantomDatafields to be used with custom derive.cc @baloo