[WIP] p384: use generic prime order formulas

Uses the generic implementation of Renes-Costello-Batina 2015 added to the `elliptic-curve` crate: RustCrypto/traits#1022
RustCrypto · Jun 12, 2022 · 560455f · 560455f
1 parent d3386b7
commit 560455f
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 516 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -10,3 +10,7 @@ members = [
 
 [profile.dev]
 opt-level = 2
+
+[patch.crates-io.elliptic-curve]
+git = "https://github.com/RustCrypto/traits.git"
+branch = "elliptic-curve/generic-prime-order-formulas"
diff --git a/p384/src/arithmetic/field.rs b/p384/src/arithmetic/field.rs
@@ -28,8 +28,8 @@ use self::field_impl::*;
 use crate::FieldBytes;
 use core::ops::{AddAssign, MulAssign, Neg, SubAssign};
 use elliptic_curve::{
-    bigint::{self, ArrayEncoding, Encoding, Integer, Limb, U384},
-    subtle::{Choice, ConstantTimeEq, ConstantTimeLess, CtOption},
+    bigint::{self, Encoding, Limb, U384},
+    subtle::{Choice, ConstantTimeEq, CtOption},
 };
 
 /// Constant representing the modulus
@@ -40,7 +40,7 @@ pub(crate) const MODULUS: U384 = U384::from_be_hex("ffffffffffffffffffffffffffff
 #[derive(Clone, Copy, Debug)]
 pub struct FieldElement(pub(super) U384);
 
-impl_field_element!(
+elliptic_curve::impl_field_element!(
     FieldElement,
     FieldBytes,
     U384,