Migrating to inline assembly (Rust 1.59) #45
Comments
|
Would you accept a PR adding a feature enabling inline asm? The use-case is that I'm cross-compiling stuff, and having a working assembler for some of the platforms I target is painful. Using rustc's built-in support for assembly would mean less moving parts for me. |
|
Yes, but the PR would have to be opened against the hashes repository, not this one. To prevent breakage, inline assembly impl should be behind its own feature (e.g. |
tarcieri
added a commit
that referenced
this issue
Jan 16, 2023
Going forward, ASM should be added directly to the relevant hashes crates using inline assembly as stabilized in Rust 1.59. See #45
tarcieri
added a commit
that referenced
this issue
Jan 16, 2023
Going forward, ASM should be added directly to the relevant hashes crates using inline assembly as stabilized in Rust 1.59. See #45
This was referenced Jul 28, 2023
|
Going to close this issue since we decided to deprecate these crates and implement ASM backands directly in the hash crates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the forthcoming release of Rust 1.59 at the end of February, which stabilizes inline assembly, I think it's time to start planning on eventually retiring this repo and migrating to inline assembly instead.
This should simplify a number of things like linking, testing, and overall crate/repo structure.
The text was updated successfully, but these errors were encountered: