Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CRTValue => CrtValue #314

Merged
merged 1 commit into from
Apr 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/key.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use zeroize::{Zeroize, ZeroizeOnDrop};
use crate::algorithms::generate::generate_multi_prime_key_with_exp;
use crate::dummy_rng::DummyRng;
use crate::errors::{Error, Result};
use crate::keytraits::{CRTValue, PrivateKeyParts, PublicKeyParts};
use crate::keytraits::{CrtValue, PrivateKeyParts, PublicKeyParts};

use crate::padding::{PaddingScheme, SignatureScheme};

Expand Down Expand Up @@ -91,7 +91,7 @@ pub(crate) struct PrecomputedValues {
/// historical accident, the CRT for the first two primes is handled
/// differently in PKCS#1 and interoperability is sufficiently
/// important that we mirror this.
pub(crate) crt_values: Vec<CRTValue>,
pub(crate) crt_values: Vec<CrtValue>,
}

impl Zeroize for PrecomputedValues {
Expand Down Expand Up @@ -276,10 +276,10 @@ impl RsaPrivateKey {
.ok_or(Error::InvalidPrime)?;

let mut r: BigUint = &self.primes[0] * &self.primes[1];
let crt_values: Vec<CRTValue> = {
let crt_values: Vec<CrtValue> = {
let mut values = Vec::with_capacity(self.primes.len() - 2);
for prime in &self.primes[2..] {
let res = CRTValue {
let res = CrtValue {
exp: BigInt::from_biguint(Plus, &self.d % (prime - BigUint::one())),
r: BigInt::from_biguint(Plus, r.clone()),
coeff: BigInt::from_biguint(
Expand Down Expand Up @@ -416,7 +416,7 @@ impl PrivateKeyParts for RsaPrivateKey {
self.precomputed.as_ref().map(|p| &p.qinv)
}

fn crt_values(&self) -> Option<&[CRTValue]> {
fn crt_values(&self) -> Option<&[CrtValue]> {
/* for some reason the standard self.precomputed.as_ref().map() doesn't work */
if let Some(p) = &self.precomputed {
Some(p.crt_values.as_slice())
Expand Down
8 changes: 4 additions & 4 deletions src/keytraits.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ pub trait PrivateKeyParts: PublicKeyParts {
fn qinv(&self) -> Option<&BigInt>;

/// Returns an iterator over the CRT Values
fn crt_values(&self) -> Option<&[CRTValue]>;
fn crt_values(&self) -> Option<&[CrtValue]>;
}

/// Contains the precomputed Chinese remainder theorem values.
#[derive(Debug, Clone)]
pub struct CRTValue {
pub struct CrtValue {
/// D mod (prime - 1)
pub(crate) exp: BigInt,
/// R·Coeff ≡ 1 mod Prime.
Expand All @@ -50,15 +50,15 @@ pub struct CRTValue {
pub(crate) r: BigInt,
}

impl Zeroize for CRTValue {
impl Zeroize for CrtValue {
fn zeroize(&mut self) {
self.exp.zeroize();
self.coeff.zeroize();
self.r.zeroize();
}
}

impl Drop for CRTValue {
impl Drop for CrtValue {
fn drop(&mut self) {
self.zeroize();
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ pub use sha2;

pub use crate::{
key::{RsaPrivateKey, RsaPublicKey},
keytraits::{CRTValue, PrivateKeyParts, PublicKeyParts},
keytraits::{CrtValue, PrivateKeyParts, PublicKeyParts},
oaep::Oaep,
padding::{PaddingScheme, SignatureScheme},
pkcs1v15::{Pkcs1v15Encrypt, Pkcs1v15Sign},
Expand Down